Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to ipfs installation guide #1547

Merged
merged 1 commit into from
Aug 5, 2015
Merged

Conversation

makevoid
Copy link
Contributor

@makevoid makevoid commented Aug 1, 2015

in Readme.md

@jbenet jbenet added the backlog label Aug 1, 2015
@GitCop
Copy link

GitCop commented Aug 1, 2015

There were the following issues with your Pull Request

  • Commit: da9d5ec
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@jbenet
Copy link
Member

jbenet commented Aug 2, 2015

Hey @makevoid thanks for the doc fix!

Would you please update your commit message with the proper license trailers?

if you run this script from within the repo: https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh

and then:

git rebase -i origin/master  # this will rebase and should add the trailers
git push origin patch-1 -f  # force push to fix the commit

it should take <30sec, though understood there is much more cognitive complexity to this than there ought to be for a one-line fix. if you prefer, i'll do it manually.

in Readme.md

License: MIT
Signed-off-by: Francesco (makevoid) <makevoid@gmail.com>
@makevoid
Copy link
Contributor Author

makevoid commented Aug 2, 2015

done, I hope to do a code PR in the future :D

thanks, very cool project!

@jbenet
Copy link
Member

jbenet commented Aug 5, 2015

thanks @makevoid!

jbenet added a commit that referenced this pull request Aug 5, 2015
Update link to ipfs installation guide
@jbenet jbenet merged commit 6944c73 into ipfs:master Aug 5, 2015
@jbenet jbenet removed the backlog label Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants