Add newline to end of ipfs object put text output.
#2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you'll also need to update the relevant sharness tests, |
nham
force-pushed
the
object_put_newline
branch
from
7cc81a9
to
8a61b53
Compare
|
There were the following issues with your Pull Request
Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue. This message was auto-generated by https://gitcop.com |
nham
force-pushed
the
object_put_newline
branch
3 times, most recently
from
b103ea8
to
1a565b0
Compare
Commands affected: - ipfs object put - ipfs tar add - ipfs resolve - ipfs name resolve License: MIT Signed-off-by: Nick Hamann <nick@wabbo.org>
nham
force-pushed
the
object_put_newline
branch
from
1a565b0
to
d49a15f
Compare
|
Per @rht's suggestion I've added newlines to the output for a few more commands: |
|
@nham there are still |
|
LGTM thanks @nham -- we can do dns and id as separate PR. |
jbenet
added a commit
that referenced
this pull request
Dec 2, 2015
Add newline to end of `ipfs object put` text output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Nick Hamann nick@wabbo.org