Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assets: fix gc example #2029

Merged
merged 1 commit into from
Dec 3, 2015
Merged

assets: fix gc example #2029

merged 1 commit into from
Dec 3, 2015

Conversation

ghost
Copy link

@ghost ghost commented Dec 3, 2015

Same as #1850 but with Signed-off-by

@ghost ghost added the RFM label Dec 3, 2015
@jbenet jbenet added the status/in-progress In progress label Dec 3, 2015
@ghost ghost mentioned this pull request Dec 3, 2015
Closed
@jbenet
Copy link
Member

jbenet commented Dec 3, 2015

and travis hates it :] -- did we break master?

@jbenet
Copy link
Member

jbenet commented Dec 3, 2015

https://travis-ci.org/ipfs/go-ipfs/jobs/94537138#L129 ?

@cryptix
Copy link
Contributor

cryptix commented Dec 3, 2015

go generate in assets/ to update bindata.go.

@ghost
Copy link
Author

ghost commented Dec 3, 2015

Damn lol that was me: assets_test.go:52: asset init-doc/quick-start: vcs and embedded data isnt equal

assets: fix gc example
dcc9a63 
License: MIT
Signed-off-by: Lars Gierth <larsg@systemli.org>
@ghost
Copy link
Author

ghost commented Dec 3, 2015

Ok here we go, updated bindata and test-lib-hashes.sh -- the remaining failure is a variation of #2027/#2028

@daviddias daviddias mentioned this pull request Dec 3, 2015
Closed
14 tasks
jbenet added a commit that referenced this pull request Dec 3, 2015
@jbenet
Merge pull request #2029 from ipfs/quickstart-gc
83246d3 
assets: fix gc example
@jbenet jbenet merged commit 83246d3 into master Dec 3, 2015
@jbenet jbenet removed the status/in-progress In progress label Dec 3, 2015
@jbenet
Copy link
Member

jbenet commented Dec 3, 2015

thanks @lgierth

@jbenet jbenet deleted the quickstart-gc branch December 3, 2015 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbenet @cryptix