Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'ipfs gc' to 'ipfs repo gc' #1850

Closed
wants to merge 1 commit into from
Closed

Changed 'ipfs gc' to 'ipfs repo gc' #1850

wants to merge 1 commit into from

Conversation

matshenricson
Copy link

No description provided.

@jbenet jbenet added the backlog label Oct 17, 2015
@GitCop
Copy link

GitCop commented Oct 17, 2015

There were the following issues with your Pull Request

  • Commit: 35d91af
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@whyrusleeping
Copy link
Member

@matshenricson You're going to have to sign off your commit to make gitcop happy. Then you will need to re-generate the assets files (check assets/README.md). Once thats done, the last step is to re-run ipfs init to get the new welcome docs hash and update that in tests/sharness/lib/test-lib-hashes.sh.

@jbenet
Copy link
Member

jbenet commented Oct 18, 2015

@matshenricson see https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh -- can just run it from go-ipfs root dir, amend the commit, and push again. something like:

cd $GOPATH/src/github.com/ipfs/go-ipfs

# setup the commit hook
wget https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh
chmod +x setup_commit_msg_hook.sh
./setup_commit_msg_hook.sh

# checkout your branch
git checkout quick-start-tiny-fix

# amend the commit
git commit --amend

# force push
git push origin quick-start-tiny-fix -f

@whyrusleeping whyrusleeping added status/in-progress In progress and removed backlog labels Oct 20, 2015
@matshenricson
Copy link
Author

Sorry for late reply. I understand that you need these license signoffs,
but it makes the process way way way too complex for me. Sorry guys, maybe
if I ever get interested in this again, but then I'll probably send emails
to you instead.

Good luck!

Mats

On Sun, Oct 18, 2015 at 9:22 AM, Juan Benet notifications@github.com
wrote:

@matshenricson https://github.com/matshenricson see
https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh
-- can just run it from go-ipfs root dir, amend the commit, and push
again. something like:

cd $GOPATH/src/github.com/ipfs/go-ipfs

setup the commit hook

wget https://github.com/ipfs/community/blob/master/dev/tools/hooks/setup_commit_msg_hook.sh
chmod +x setup_commit_msg_hook.sh
./setup_commit_msg_hook.sh

checkout your branch

git checkout quick-start-tiny-fix

amend the commit

git commit --amend

force push

git push origin quick-start-tiny-fix -f


Reply to this email directly or view it on GitHub
#1850 (comment).

@jbenet
Copy link
Member

jbenet commented Oct 28, 2015

@matshenricson it literally takes < 30s to setup the hook + amend commits. and this is standard for many large projects, like Git, the Linux Kernel, Docker, ...

@matshenricson
Copy link
Author

I like to know what I'm doing, and "hook + amend" are two words I've never
ever heard of before. Probably because I'm way behind the 1337 crowd, but
none the less.

Mats

On Wed, Oct 28, 2015 at 2:18 PM, Juan Benet notifications@github.com
wrote:

@matshenricson https://github.com/matshenricson it literally takes <
30s to setup the hook + amend commits. and this is standard for many large
projects, like Git, the Linux Kernel, Docker, ...


Reply to this email directly or view it on GitHub
#1850 (comment).

@whyrusleeping
Copy link
Member

alright, i'll pick this one up

@rht
Copy link
Contributor

rht commented Nov 2, 2015

< 30s to just write the sign-off by hand.

@ghost ghost mentioned this pull request Dec 3, 2015
@ghost
Copy link

ghost commented Dec 3, 2015

#2029

@ghost ghost closed this Dec 3, 2015
@jbenet jbenet removed the status/in-progress In progress label Dec 3, 2015
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants