Make dns resolve paths under _dnslink.example.com #2184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
Kubuxu
force-pushed
the
feature/dnslink
branch
from
176db3a
to
96d5a9f
Compare
|
Fixed sign-offs (I forgot to add hook, again). Also if you have any comments to the code, I would love to hear them. If anything could have been done better... I am not proficient in Go. |
ghost
mentioned this pull request
Kubuxu
force-pushed
the
feature/dnslink
branch
from
96d5a9f
to
ade1982
Compare
whyrusleeping
force-pushed
the
dev0.4.0
branch
from
cf514d8
to
3224ae0
Compare
Thus allowing to CNAME main site entry to gateway and stil specify dnslink. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@gmail.com>
License: MIT Signed-off-by: Jakub Sztandera <kubuxu@gmail.com>
Kubuxu
force-pushed
the
feature/dnslink
branch
from
ade1982
to
ceac63e
Compare
|
Replaced by #2191. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus allowing to CNAME main site entry to gateway and still specify
dnslink.
Resolves ipfs/notes#39. Option 4 and 5.
Would be great if merged with #2139, and shouldn't even conflict (depending on merger).