Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust version checking #2246

Closed
wants to merge 1 commit into from
Closed

More robust version checking #2246

wants to merge 1 commit into from

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 25, 2016

@jedahan's PR #2100 with the signoff fixed.

@GitCop
Copy link

GitCop commented Jan 25, 2016

There were the following issues with your Pull Request

  • Commit: c0382be
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@rht rht force-pushed the smarter-launchd-install branch from c0382be to dce12fc Compare January 25, 2016 04:10
@rht
More robust version checking
a47496c 
Attribution:
jedahan@3419e45
by @jedahan is licensed under MIT license

License: MIT
Signed-off-by: rht <rhtbot@gmail.com>
@rht rht force-pushed the smarter-launchd-install branch from dce12fc to a47496c Compare January 25, 2016 15:27
@rht
Copy link
Contributor Author

rht commented Jan 25, 2016

Attribution fixed.

@rht
Copy link
Contributor Author

rht commented Jan 27, 2016

cc @germonprez to shed some light here.

@whyrusleeping
Copy link
Member

I don't think we can do this. We can rewrite the fix ourselves, but this is applying a different license to code than the author intended (whether on purpose or not).

@rht rht mentioned this pull request Jan 30, 2016
Merged
@rht
Copy link
Contributor Author

rht commented Jan 30, 2016

It might be possible to do this, ref: #2100 (comment).

@rht
Copy link
Contributor Author

rht commented Jan 30, 2016

I'm signing this off under rht, not jedahan. The remaining issue is attribution.

@whyrusleeping
Copy link
Member

mmm, okay. that sounds feasible... i guess we should ping a lawyer or something (which it looks like you might have already done)

@whyrusleeping
Copy link
Member

would also be good to set a pre-receive hook on the server to flat out reject any commits that don't have a proper signoff (not sure if we can do that)

@rht rht closed this Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rht @GitCop @whyrusleeping