-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change link to dist to be under IPNS in readme #2417
Conversation
There were the following issues with your Pull Request
We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity. This message was auto-generated by https://gitcop.com |
IDK why gitcop doesn't like that commit message. |
Agreed, that sign off seems fine. cc @chriscool Shouldn't we fix the dist, rather than repoint through the gateway? |
@Kubuxu could you try to put a blank line just before the "License: MIT" line? |
Otherwise there is invalid cert error. License: MIT Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
Repointing might be a good idea but you can't do that before bad-cert error. Repushed this time gitcop is not complaining. |
we're working on getting a wildcard cert, but this is a decent stopgap until then. cc @lgierth |
Repoint it to either http:// or https://ipfs.io/ipns/, I'll go through everything with a script once the wildcard cert is up |
In that case, this is RFM. |
cool, merging. Thanks @Kubuxu! |
Change link to dist to be under IPNS in readme
Otherwise there is invalid cert error.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch