fix: listen on loopback for API and gateway ports in docker-compose.yaml #8773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
approved these changes
Mar 8, 2022
| # The following ports only listen on the loopback interface, so are not remotely reachable by default. | ||
| # If you want to override these or add more ports, see https://docs.docker.com/compose/extends/ . | ||
|
|
||
| # API port, which includes admin operations, so you probably don't want this remotely accessible. |
There was a problem hiding this comment.
Just saying "you shouldn't do that" or alike isn't enough for people to not do it.
We need to propose alternative solutions.
In a future patch I'll add a link to docs explaining SSH tunnels and reverse proxy (don't exists yet).
aschmahmann
approved these changes
Mar 9, 2022
guseggert
added a commit
that referenced
this pull request
Mar 10, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Jorropo