Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: listen on loopback for API and gateway ports in docker-compose.yaml #8773

Merged
merged 1 commit into from
Mar 9, 2022
Merged

fix: listen on loopback for API and gateway ports in docker-compose.yaml #8773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,18 @@ services:
environment:
- IPFS_PATH=/data/ipfs
ports:
# Swarm listens on all interfaces, so is remotely reachable.
- 4001:4001/tcp
- 4001:4001/udp
- 5001:5001
- 8080:8080
- 8081:8081

# The following ports only listen on the loopback interface, so are not remotely reachable by default.
# If you want to override these or add more ports, see https://docs.docker.com/compose/extends/ .

# API port, which includes admin operations, so you probably don't want this remotely accessible.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saying "you shouldn't do that" or alike isn't enough for people to not do it.
We need to propose alternative solutions.

In a future patch I'll add a link to docs explaining SSH tunnels and reverse proxy (don't exists yet).

- 127.0.0.1:5001:5001

# HTTP Gateway
- 127.0.0.1:8080:8080
volumes:
ipfs_path:
ipfs_fuse:
Expand Down