Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to libipfs bitswap #9424

Closed
wants to merge 1 commit into from
Closed

Conversation

guseggert
Copy link
Contributor

No description provided.

@Jorropo
Copy link
Contributor

Jorropo commented Nov 22, 2022

go-bitswap is used by many other pieces of software, it's also big and we don't touch it often.

I don't think it's worth moving into libkubo

@guseggert
Copy link
Contributor Author

guseggert commented Dec 2, 2022

The criteria for moving repos into libipfs isn't "unused, small, and unchanging"...the goal is to get all of our repos into one place, big and small, popular and unpopular. (Of course there will be exceptions to this, but they should be exceptions, and we should have a good practical reason for not moving them.) Also consider that part of the reason we don't touch it often is because the plumbing is painful.

The tactical reason I am opening this now is because it is big and used by many other components, so it's a good stress test of the process for migrating repos into libipfs.

@guseggert guseggert changed the title chore: switch to libkubo bitswap chore: switch to libipfs bitswap Dec 2, 2022
@guseggert guseggert mentioned this pull request Dec 2, 2022
5 tasks
@guseggert guseggert self-assigned this Dec 24, 2022
@guseggert guseggert closed this Jan 27, 2023
@hacdias hacdias deleted the chore/migrate-go-bitswap branch May 9, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants