Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: import go-bitswap #6

Closed
wants to merge 1,203 commits into from
Closed

chore: import go-bitswap #6

wants to merge 1,203 commits into from

Conversation

guseggert
Copy link
Contributor

@guseggert guseggert commented Dec 2, 2022

Note there are flaky tests in go-bitswap that have been ignored for a long time. These will get more painful with this change because we'll be running them more often.

IMO forcing ourselves to deal w/ the pain of these flaky tests is the only way to actually fix them, as "good intentions" haven't worked for a long time here.

Corresponding PR wiring this change into Kubo: ipfs/kubo#9424

Todo:

dirkmc and others added 30 commits March 6, 2020 09:58
This commit was moved from ipfs/go-bitswap@e12b69e
This commit was moved from ipfs/go-bitswap@cc1224e
This commit was moved from ipfs/go-bitswap@568a984
Be less aggressive when pruning peers from session

This commit was moved from ipfs/go-bitswap@418d88c
…eers

Simulate DONT_HAVE when peer doesn't respond to want-block (new peers)

This commit was moved from ipfs/go-bitswap@3a82e57
We use these outside of bitswap for testing.


This commit was moved from ipfs/go-bitswap@b58f8fc
fix: re-export testinstance/testnet

This commit was moved from ipfs/go-bitswap@de62939
…ontHaveTimeoutMgrTimeout

fix flaky TestDontHaveTimeoutMgrTimeout

This commit was moved from ipfs/go-bitswap@df360b3
…itingRequests

fix flaky TestRateLimitingRequests

This commit was moved from ipfs/go-bitswap@12021fa
…t-wants

Fix order of session broadcast wants

This commit was moved from ipfs/go-bitswap@cd14e70
marten-seemann and others added 23 commits April 22, 2022 08:45
* feat: batch and queue connection event handling

* address feedback

* fix: mark responsive on new connection

This commit was moved from ipfs/go-bitswap@a06a9ea
This adds tracing spans to the costly Bitswap entry points. It doesn't
instrument the bitswap internals, which will take some time. In
go-ipfs, this will at least let us know the contribution of Bitswap to
the overall request handling time.

This also plumbs contexts through internally so that they reach the
content routing APIs, so that traces are propagated through and we can
start instrumenting e.g. the DHT.

This commit was moved from ipfs/go-bitswap@b18a91d
Remove dependency on travis package from go-libp2p-testing

This commit was moved from ipfs/go-bitswap@8497368
This leave the responsibility and choice to do so to the caller, typically go-blockservice.

This has several benefit:
- untangle the code
- allow to use an exchange as pure block retrieval
- avoid double add

Close ipfs/kubo#7956


This commit was moved from ipfs/go-bitswap@a052ec9
Don't add blocks to the datastore

This commit was moved from ipfs/go-bitswap@1d1c6bf
This test is exceptionally racy and IMO useless (you can go read the 10 lines of code making up tracing and convaince yourself it's working.)


This commit was moved from ipfs/go-bitswap@1ac4824
feat: split client and server

This commit was moved from ipfs/go-bitswap@5b013e0
This remove the github.com/libp2p/go-libp2p-loggables because AFAIT this is not usefull anymore (we use tracing now).

If people care about uuids in logs, we should log sessions in go-log instead.


This commit was moved from ipfs/go-bitswap@475c27c
@guseggert guseggert changed the title Migrate go bitswap chore: import go-bitswap Dec 2, 2022
@guseggert guseggert self-assigned this Dec 2, 2022
guseggert pushed a commit that referenced this pull request Dec 6, 2022
@Jorropo Jorropo self-requested a review January 18, 2023 12:19
@Jorropo Jorropo mentioned this pull request Jan 26, 2023
5 tasks
@Jorropo Jorropo closed this Jan 27, 2023
@hacdias hacdias deleted the migrate-go-bitswap branch June 27, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.