-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPIP-428: Allowing V2-Only Records in IPNS #428
Conversation
initial draft for early feedback
@@ -259,9 +285,91 @@ Finally, the network nodes may also republish their records, so that the records | |||
|
|||
### Record Creation | |||
|
|||
IPNS record MUST be serialized as `IpnsEntry` protobuf, and `IpnsEntry.data` MUST be signed using the private key. | |||
IPNS record MUST be serialized as `IpnsEntry` protobuf, and `IpnsEntry.data` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could rename IpnsEntry
to IpnsRecord
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not against it, but want to limit what we change in IPIP to minimum, so it is easier to review.
Let's make a separate editorial PR after this IPIP lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the updates conform to the changes we've made to Boxo in ipfs/boxo#339
Co-authored-by: Henrique Dias <hacdias@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for final reviews.
Reference implementation in GO lives in boxo/ipns
and shipped with Kubo 0.22:
We have wip js-ipns
version as well:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied final editorials and included test vectors from ipfs/gateway-conformance#157
Flagged during IPFS Implementers call multiple times, no concerns were raised about ratification.
Merging to ensure https://specs.ipfs.tech/ipns/ipns-record/ is up-to-date and includes test vectors.
Closes #376
This IPIP introduces support for creation and validation of compact, V2-only IPNS Records.