This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Add hash algorithm option for cid #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zcstarr Please see ipld/interface-ipld-format#22 for the upcoming changes of the IPLD format spec. Those changes (once accpeted and merged) would then needed to be implemented for all currently supported formats (Bitcoin, CBOR, Ethereum, Zcash, Git, PB) |
vmx
added
status/ready
|
@zcstarr Sorry for taking so long. Now that the spec got updated, there's a |
|
PR #66 resolves #62 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually in relation to changing ipld/js-ipld#82 , where the ipfs resolver put interface needs to pass through the hashAlg to the various ipld resolver utils. This will be a breaking change as the the interface would change from (dagNode,callback) to (dagNode, hashAlg, callback) . If this change makes since, then I'll also patch up the other ipld packages. @diasdavid