feat: add util.cid options #66
Conversation
src/util.js
Outdated
| * @returns {void} | ||
| */ | ||
| exports.cid = (dagNode, options, callback) => { | ||
| if (options instanceof Function) { |
There was a problem hiding this comment.
Searching through the existing IPFS/IPLD code base it seems that the preferred way for checking if something is a function is: if (typeof options !== 'function') {. My guess is that it is related to code minifiers. Please change it.
src/util.js
Outdated
| } | ||
| options = options || {} | ||
| const hashAlg = options.hashAlg || resolver.defaultHashAlg | ||
| const version = options.version || 1 |
There was a problem hiding this comment.
This doesn't work correctly. If options.version is set to 0, then version would become 1 as 0 evaluates to false.
|
The only error cases, that I can think of, are an invalid version or hash algorithm. Both cases should be handled by by underlaying software, |
There was a problem hiding this comment.
Good point. Often things are not handled correctly, but you are right, it should be handled by the underlying libraries. Could you have a quick look to see if they do handle it and if not open issues on those? If that's a too big ask, let me know and I'll check myself.
I'll also approve the other PRs where I mentioned the same thing.
|
Please squash merge (as mentioned on the other PRs :) |
|
I'll look into the libraries and report back. I'm |
|
I'm |
See ipld/interface-ipld-format#40
Closes #62