Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 2.2 unit tests to 3.0 if necessary, remove 2.2 unit tests folder #201

Closed
bquinn opened this issue Oct 28, 2024 · 1 comment · Fixed by #157
Closed

Move 2.2 unit tests to 3.0 if necessary, remove 2.2 unit tests folder #201

bquinn opened this issue Oct 28, 2024 · 1 comment · Fixed by #157
Assignees
Labels
done The suggestion has been done in the schema etc.
Milestone

Comments

@bquinn
Copy link
Contributor

bquinn commented Oct 28, 2024

https://github.com/iptc/newsinjson/tree/events-planning/validation/test_suite/2.2/should_pass

It may require modifying the test runner Python script at https://github.com/iptc/newsinjson/blob/events-planning/validation/python/runtests.py

(we also noticed that there is a main.py in the folder, maybe check that the README and main.py are up to date and if main.py is needed at all??)

@bquinn bquinn added this to the 3.0 milestone Oct 28, 2024
@iyoung
Copy link
Contributor

iyoung commented Nov 6, 2024

Hi @bquinn I've added these changes in #210 if you get the chance to review. I think we should squash merge these vs just a merge to tidy the history if that's ok.

bquinn added a commit that referenced this issue Nov 8, 2024
Unit tests moved to 3.0 folder. Unit test runner changed to run 3.0 tests.

Fixes #200, #201, #202
@iyoung iyoung added the done The suggestion has been done in the schema etc. label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done The suggestion has been done in the schema etc.
Projects
None yet
2 participants