Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ninjs 3.0 release candidate, including events, planning, live streams and camelCase properties #157

Merged
merged 97 commits into from
Nov 26, 2024
Merged

ninjs 3.0 release candidate, including events, planning, live streams and camelCase properties #157

merged 97 commits into from
Nov 26, 2024

Conversation

bquinn
Copy link
Contributor

@bquinn bquinn commented Aug 7, 2023 •
edited
Loading

Main PR for ninjs version 3.0.

Merging this will fix #157, #159, #161, #165, #201 , #202, #203, #209, #213 and more...

@bquinn
Added new 2.2 schema file, with a draft first pass at handling events…
b824e0f 
… a la EventsML-G2.

Added unit test cases and added 2.2 support to Python test runner.
@bquinn bquinn changed the title Added new 2.2 schema file, with a draft first pass at handling events a la EventsML-G2. draft first pass at handling events a la EventsML-G2. Aug 7, 2023
iyoung
iyoung reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@iyoung iyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw these small tweaks but notice that Johan has a number of other suggestions in the Slack channel

specification/ninjs-schema_2.2.json Outdated Show resolved Hide resolved
specification/ninjs-schema_2.2.json Outdated Show resolved Hide resolved
@bquinn bquinn changed the title draft first pass at handling events a la EventsML-G2. draft ninjs version that handles events and planning items a la EventsML-G2 Sep 25, 2023
bquinn and others added 17 commits September 29, 2023 16:43
@bquinn
Updates to align with agreed approach after last ninjs WG meeting - s…
63aafbc 
…ingle

event per item.
@iyoung
example-event: added example event
6c73949 
This is an example event supplied by Trond using NinJS 2.2
@iyoung
example-folder: added 2.2 examples
b026d43
@jolla56
Create tt_event_sample
0acd3ce
@jolla56
Rename tt_event_sample to tt_event_sample.json
53d2a4e
@jolla56
Create tt_event_2.2.json
06779bb
@iyoung
updated simple event
e3c699d 
added some additional detail around urls for example
@trondhuso
Cleaned up examples
5f85abd
@trondhuso
Adding press conference example
ee7513e
@trondhuso
Added persons who attends the press conference
412b401
@trondhuso
minor changes to different addb-related events. Added a Champion Leag…
ba51c45 
…ue mark up
@jolla56
Rename tt_event_sample.json to tt_event_pressconference_sample.json
637b847
@jolla56
Rename tt_event_2.2.json to tt_event_pressconference_2.2.json
45262ae
@bquinn
Two fixes to schema so tests should now pass.
9a74a4a
@bquinn
Update version number in JSON schema header and note that this is a w…
5b3dc87 
…ork in progress
@bquinn
Merge pull request #158 from iptc/events-planning-examples
98cce7e 
example-event: added example event
@bquinn
Add renditions to plannedcoverage objects. Add video-specific charact…
434b7e9 
…eristics to renditions object. (#160)

* Support for renditions in plannedcoverage objects, based on work with DPP team including Arqiva, Reuters and CNN.
* Added commissioning structure to schema (under plannedcoverage).
* reformatting schema: to standardise indents
---------
Co-authored-by: jolla56 <jl@tt.se>
Co-authored-by: Ian Young <ian@iansramblings.com>
@bquinn bquinn changed the title draft ninjs version that handles events and planning items a la EventsML-G2 ninjs 2.2 release candidate, including events, planning and renditions to support live streaming events Feb 13, 2024
@bquinn bquinn marked this pull request as ready for review February 13, 2024 04:29
@iyoung
fix for cidr pattern remove ipv4 restriction
37a4454
@iyoung
fix(duplicate-property): remove duplicate property rendition
1de1c00 
this property duplicates the existing width and height in rendition
@iyoung
Merge pull request #167 from iptc/fix/remove-resolution
4318f02 
fix(duplicate-property): remove duplicate property rendition
@iyoung
feat(dates-option): support truncated and accurate dates
e686f45 
this is a response to feedback around the truncated date time for start and end date
@iyoung
feat(news-item-planned): add test example planned coverage
fc993fb 
links from news item to the planned coverage via associations
bquinn and others added 3 commits November 11, 2024 18:09
@bquinn
Added refinement to specify expectedDuration property. Fixes #216.
8cae52e
@bquinn
Merge pull request #218 from iptc/fix/expectedDuration-desc
e224a44 
Added refinement to specify expectedDuration property. Fixes #216.
@bquinn
3.0 docs (#212)
93befbd 
* Updated docs to cover ninjs 1.5, 2.1 *and* 3.0. Using a nifty tab plugin that @iyoung found.
Thanks to @jolla56 for reviewing the draft.
@bquinn bquinn requested a review from iyoung November 14, 2024 14:11
This was linked to issues Nov 14, 2024
Review/tidy-up of proposed rendition properties #194
Closed
Tidy up schema comments for 3.0 release #196
Closed
Move 2.2 examples to 3.0 if necessary and remove the examples.2.2 folder from PR branch #200
Closed
Move 2.2 unit tests to 3.0 if necessary, remove 2.2 unit tests folder #201
Closed
Check that javascript unit test runner works with 3.0 #202
Closed
Documentation for events and planning in ninjs User Guide #206
Closed
Documentation for properties in ninjs 1.x, 2.x and 3.0 #207
Closed
ninjs 3.0 errata: types in recurrence rules #213
Closed
Refine "expectedDuration" property in schema #216
Closed
@bquinn
3.0 docs update (#220)
40294ba 
* Update docs to refer to new eventstatus CV
iyoung
iyoung previously approved these changes Nov 25, 2024
View reviewed changes
@iyoung
Copy link
Contributor

iyoung commented Nov 25, 2024

@bquinn one very minor tweak https://github.com/iptc/newsinjson/pull/157/files#diff-571c94ec512a44c307bf3c4bd2781cb00a33bb5e5b5f7d4071442a7e8a270b58L1173 I think that can now also be changed to the 3.0 link

@bquinn bquinn requested a review from jolla56 November 25, 2024 16:09
@jolla56
Copy link
Contributor

jolla56 commented Nov 26, 2024

In the readme:

Version 3.0 offers three document types, the existing “newsItem” and a new
document types event and planning. For improved readability and for aligning
with general best practise for variable naming and graphQL the properties now
use camel case.
7:43
a new document types
7:43
sounds to me as a mix of singular and plural
7:45
Should this line include 3.0?
7:45
user-facing tool to generate sample ninjs files of either 1.5 or 2.1 version, which is hosted at

jolla56
jolla56 previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@jolla56 jolla56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a separate comment I noted some things in the readme that maybe should be fixed. But not crucial.

@bquinn bquinn requested a review from iyoung November 26, 2024 07:26
@bquinn bquinn merged commit 5a1e5cd into main Nov 26, 2024
1 check passed
@bquinn bquinn deleted the events-planning branch November 26, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jolla56 jolla56 jolla56 left review comments

@iyoung iyoung Awaiting requested review from iyoung

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0
4 participants
@bquinn @iyoung @jolla56 @trondhuso