Remove strip_output_prompt #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like the import in https://travis-ci.org/ipython-contrib/jupyter_contrib_nbextensions/jobs/189658004#L2118 needs removing, along with the relevant tests & edit to the conda recipe import-test |
|
Yep, some things were still missing. |
jcb91
reviewed
Jan 8, 2017
| @@ -18,3 +18,6 @@ Internals | |||
|
|
|||
| The codecell hiding state is stored in the metadata `IPython.notebook.metadata.hide_input`. | |||
| If it is set to `true`, all codecells will be hidden on reload. | |||
|
|
|||
| Exporting using `nbconvert` is currently not supported. | |||
There was a problem hiding this comment.
I think the same metadata value is set as in hide_input, in which case the same export advice as there should work? Or perhaps I've misunderstood/misremembered
There was a problem hiding this comment.
It currently does not work. It should, so I am adding this now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use updated template from jupyter/nbconvert#500