-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block to allow customizing html output prompt #500
Conversation
Thanks, I think this is a reasonable addition. Can you add it to the template structure doc, which is rendered at: |
Should be good to go. |
<div class="template_block">execute_result</div> | ||
<div class="template_block">output_area_prompt | ||
<div class="template_block">execute_result</div> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is quite right:
- The new block goes before the output content blocks (like
execute_result
), not wrapping them. - The new block is only in the HTML template; there's a separate section below for extra blocks in the HTML template.
Added a block around the HTML template's version of the cell output prompt.
Hey @michaelpacer, based on @takluyver's comments I dropped your commit, but thanks for helping out, I definitely wouldn't have noticed I needed to update the notebook otherwise! @takluyver, I think the HTML structure is now correct. I wasn't sure how best to state the block inheritance, so I just went for an explicit |
Thanks! I think |
@takluyver thanks for the feedback! I think all done. |
Thanks :-) |
This may have broken rtd. |
@michaelpracer hey, sorry what's rtd mean? |
@michaelpacer |
Readthedocs I.e., http://nbconvert.readthedocs.io
I got an email warning of its failure this morning and this is the pr that
merged around then.
…On Wed, Dec 28, 2016 at 10:42 Elliot Marsden ***@***.***> wrote:
@michaelpacer <https://github.com/michaelpacer>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#500 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACXg6Mz0Yy_gIufLiGTdukexiw0BayiGks5rMq2PgaJpZM4LS7cX>
.
|
Thanks for catching this. I'm not familiar with how readthedocs works, where can I see its build details? I can see that it looks like the ipython notebook with the template structure is shown there, but the PR changes aren't reflected, even in its 'latest' version. |
I think Mike has got it working again, but for the record, you can see RTD build logs here: https://readthedocs.org/projects/nbconvert/builds/ |
I think it ended up being independent of this PR per se (it was just what triggered the most recent failure), so no worries. |
For generating HTML reports I usually want to completely hide cells' output, apart from a select few types such as HTML and images. I can almost accomplish this with a custom template inheriting from
full.tpl
, except that I can't hide the output prompt without hiding the cell output itself. I can if I add this block.