Use shell.input_transformer_manager when available #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why the 3.4 build is failing. I'd like to remove 3.4 support as part of a minor release. Skipping this for the patch release. Thanks for the fix and your patience @dandavison! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375
With this change we don't trigger the deprecation warning on
ipython.core.InteractiveShellif we can avoid it.Testing
I started a kernel (using
ipykernel.kernelapp.launch_new_instance) on this commit, and on the parent b81632e, and connected to it withjupyter console, and confirmed that the deprecation message appeared at the prompt when executing code on b81632e, but was not present on this commit.