Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release notes for 5.1.3 #434

Merged
merged 5 commits into from
Oct 20, 2019
Merged

Add release notes for 5.1.3 #434

merged 5 commits into from
Oct 20, 2019

Conversation

blink1073
Copy link
Contributor

@ccordoba12
Copy link
Member

@blink1073, could you also take a look at #435 before releasing 5.1.3?

willingc
willingc approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would clarify the addition of deleting. LGTM.

docs/changelog.rst Outdated Show resolved Hide resolved
@SylvainCorlay
Copy link
Member

Thanks!

⚠️ Quick heads up: when this gets released, we should not merge the conda-forge cf-auto-tick PR as-is.

We should use the opportunity to simplify the installation https://github.com/conda-forge/ipykernel-feedstock/blob/master/recipe/meta.yaml#L15-L18 since the kernelspec from will now include the proper path when installing from a source tarball.

willingc
willingc approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @blink1073

@blink1073
Copy link
Contributor Author

TODO: add #437 and perhaps #411 if CI passes

@blink1073 blink1073 changed the title Add release notes for 5.1.3 [WIP] Add release notes for 5.1.3 Sep 16, 2019
@blink1073 blink1073 changed the title [WIP] Add release notes for 5.1.3 Add release notes for 5.1.3 Sep 17, 2019
@minrk minrk mentioned this pull request Sep 27, 2019
Merged
@blink1073 blink1073 merged commit 3313557 into ipython:master Oct 20, 2019
@blink1073
Copy link
Contributor Author

ipykernel-5.1.3-py3-none-any.whl and ipykernel-5.1.3-py3-none-any.whl are now available on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainCorlay SylvainCorlay SylvainCorlay approved these changes

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blink1073 @ccordoba12 @SylvainCorlay @willingc @minrk