use packaging instead of pkg_resources to parse versions #900
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning setuptools as a runtime dependency is often a problem, and setting a minimum of extremely recent setuptools 60 is causing conflicts with e.g. pandas which pins
setuptools<60
(this is making an unsolvable conda environment for me right now).migration advice suggests using the lighter
packaging
package, and I don't see a reason to use a version pin.The pkg_resources function is also available for at least 30 versions (setuptools 30), so the
>=60
doesn't seem to have been the right number to use.Recommend a patch release with the fix, since the dependency in 6.11 is causing installation problems.