setup.py fixes #680
Merged
setup.py fixes #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
minrk
commented
Mar 25, 2022
minrk
commented
- update jupyter-packaging to 0.12 (fixes compatibility with setuptools 61)
- workaround Figure out how to support dynamic data_files jupyter/jupyter-packaging#127 by ensuring build has been run once prior to computing data_files
- avoid redundant rebuild of js when installing from sdists (closes pip install failed: js contenthash changed #675)
- if labextension not present, build before computing data_files (fixes incorrect data files when doing `pip install .` from git - if labextension present and not building from a repo, skip rebuild to avoid redundant js rebuilds from an sdist
This was referenced Apr 1, 2022
Merged
stephenmsachs
added a commit
to stephenmsachs/spack
that referenced
this pull request
Jul 6, 2022
adamjstewart
pushed a commit
to spack/spack
that referenced
this pull request
Jul 7, 2022
* [py-ipyparallel] setuptools.config.StaticModule moved ... in py-setuptools@61 * [py-ipyparallel] setuptools fix only added to release 8.2.1 ipython/ipyparallel#680 * [py-ipyparallel] Fix typo Co-authored-by: Stephen Sachs <stesachs@amazon.com>
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
* [py-ipyparallel] setuptools.config.StaticModule moved ... in py-setuptools@61 * [py-ipyparallel] setuptools fix only added to release 8.2.1 ipython/ipyparallel#680 * [py-ipyparallel] Fix typo Co-authored-by: Stephen Sachs <stesachs@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.