-
-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the Comm Python package #973
Conversation
da6e9ec
to
aeaaf80
Compare
0fe77b6
to
a9556dd
Compare
f60a46f
to
48524de
Compare
for more information, see https://pre-commit.ci
50e9e54
to
b11a831
Compare
I marked the PR as ready to review! I might be wrong but the ipyparallel issue seems unrelated?
|
Correct |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'll cut a minor release with this change early next week. |
@blink1073, is there full compatibility for projects that import the |
Yes, the equivalent classes are exported from the |
This broke compatibility in Solara, since I was doing Giving me:
Not sure if this should be considered a public API (the constructor), if so, happy to open an issue. |
@martinRenou really nice to see this out this soon btw :) congrats |
I think the cause is the same as #1026 |
This reverts commit 6607b9d.
Currently working on a Python comm package on https://github.com/martinRenou/comm for now, but it should probably be moved in the IPython orgThis PR relies on the new comm package https://github.com/ipython/comm
This has the benefit of being able to: