Pin ipykernel so Jdaviz doesn't crash #1876
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
added
trivial
rosteen
requested review from
duytnguyendtn,
javerbukh,
ojustino,
pllim,
kecnry and
bmorris3
as code owners
Codecov ReportBase: 88.37% // Head: 88.37% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1876 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 95 95
Lines 10456 10456
=======================================
Hits 9241 9241
Misses 1215 1215 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think it's better ipykernel gets yanked: ipython/ipykernel#1040 |
|
Looks like the release was yanked (ipython/ipykernel#1040 (comment)). So we don't need this anymore? Also for my own notes: ipython/ipykernel#973 and ipython/ipykernel#1026 |
|
They yanked the release, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ipykernel 6.18 changed the way comm messages are handled apparently, which completely broke Jdaviz. @maartenbreddels is looking into it, but in the meantime we need to pin this to a working version. Might need to cut a new bugfix release with this.