Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency typescript to v3.9.5 #278

Merged
merged 12 commits into from
Jun 17, 2020
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 16, 2020

This PR contains the following updates:

Package Type Update Change
typescript (source) devDependencies minor 3.5.3 -> 3.9.5

Release Notes

Microsoft/TypeScript

v3.9.5

This release contains bug fixes in type-checking, emit, and editor scenarios.

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

(note, 3.9.4 was intentionally skipped due to minor complications in publishing)

Downloads are available on:

v3.9.3

Compare Source

This release contains bug fixes in type-checking, APIs, emit, and editor scenarios.

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.9.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.8.3

Compare Source

For release notes, check out the release announcement.

For new features, check out the What's new in TypeScript v3.8.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.8.2

Compare Source

For release notes, check out the release announcement.

For new features, check out the What's new in TypeScript v3.8.2.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.7.5

Compare Source

For the complete list of fixed issues, check out the

v3.7.4

Compare Source

For the complete list of fixed issues, check out the

Downloads are available on:

v3.7.3

Compare Source

For the complete list of fixed issues, check out the

Downloads are available on:

v3.7.2

Compare Source

For release notes, check out the release announcement.

For new features, check out the What's new in TypeScript v3.7.2.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.6.5

Compare Source

This patch fixes an issue where TypeScript would erroneously report the following error under noImplicitAny when encountering a private get accessor in a .d.ts file.

Property 'myGetter' implicitly has type 'any', because its get accessor lacks a return type annotation.

This is an issue when using packages published from TypeScript 3.7 and newer. Users can upgrade to 3.6.5 to fix the issue.

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.6.4

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.6.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v3.6.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate
Copy link
Contributor Author

renovate bot commented Feb 16, 2020

Branch automerge failure

This PR was configured for branch automerge, however this is not possible so it has been raised as a PR instead.


  • Branch has one or more failed status checks

@renovate renovate bot force-pushed the renovate/typescript-3.x branch 8 times, most recently from 39c26f0 to bd30eff Compare February 20, 2020 22:58
@renovate renovate bot changed the title chore(deps): update dependency typescript to v3.7.5 chore(deps): update dependency typescript to v3.8.2 Feb 20, 2020
@renovate renovate bot changed the title chore(deps): update dependency typescript to v3.8.2 Update dependency typescript to v3.8.2 Feb 21, 2020
@renovate renovate bot force-pushed the renovate/typescript-3.x branch 5 times, most recently from 2918084 to db6bf19 Compare February 29, 2020 00:04
@renovate renovate bot changed the title Update dependency typescript to v3.8.2 Update dependency typescript to v3.8.3 Feb 29, 2020
@renovate renovate bot force-pushed the renovate/typescript-3.x branch 5 times, most recently from 852686f to 3e129d6 Compare February 29, 2020 11:46
@renovate renovate bot force-pushed the renovate/typescript-3.x branch 7 times, most recently from 682766f to b9ac635 Compare March 31, 2020 19:58
@renovate renovate bot force-pushed the renovate/typescript-3.x branch 10 times, most recently from 62c10b6 to df7c9d1 Compare June 17, 2020 14:07
@renovate renovate bot force-pushed the renovate/typescript-3.x branch from df7c9d1 to 7eb37b7 Compare June 17, 2020 15:09
@renovate renovate bot force-pushed the renovate/typescript-3.x branch from 7eb37b7 to 6019194 Compare June 17, 2020 17:35
I modified indent_style back to "space" in .editorconfig to avoid too
much changes in this commit's diff.

We still have the following problem: "error TS5053: Option 'noEmit'
cannot be specified with option 'composite'."
@renovate
Copy link
Contributor Author

renovate bot commented Jun 17, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

If you think this comment is in error and the branch is not modified, try deleting this comment. If it comes back again the next time Renovate runs, please submit an issue or seek config help.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2020

Codecov Report

Merging #278 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #278   +/-   ##
=======================================
  Coverage   23.08%   23.08%           
=======================================
  Files         105      105           
  Lines        1412     1412           
  Branches      230      218   -12     
=======================================
  Hits          326      326           
- Misses       1085     1086    +1     
+ Partials        1        0    -1     
Impacted Files Coverage Δ
packages/api/src/__generated__/resolvers-types.ts 0.00% <ø> (ø)
...api/src/__tests__/resolvers/__utils/mockContext.ts 100.00% <ø> (ø)
packages/api/src/utils.ts 27.27% <ø> (ø)
packages/web/src/components/ThemeContext.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c0b94...9c3c72b. Read the comment docs.

@iquabius
Copy link
Owner

iquabius commented Jun 17, 2020

So, TS options "declaration" and "composite" doesn't work with "noEmit":

"error TS5053: Option 'noEmit' cannot be specified with option 'composite'."

microsoft/TypeScript#36917

The revert was reverted again in microsoft/TypeScript#36483 because, per microsoft/TypeScript#32882, it really doesn't make sense to have incremental and noEmit together, since noEmit prevents us from writing incremental metadata. (So nothing is actually incremental).

You should consider emitDeclarationOnly instead of noEmit, if you actually just want incremental checking.

Posted by @weswigham in microsoft/TypeScript#33809 (comment)

That's why this TS update was a mess. It seems composite projects / incremental builds doesn't work well with projects that use Babel, like Next.js/React apps.

@iquabius iquabius merged commit 184e555 into master Jun 17, 2020
@iquabius iquabius deleted the renovate/typescript-3.x branch June 17, 2020 21:13
Comment on lines +1 to +9
{
"files": [],
"references": [
{ "path": "api" },
// "error TS5053: Option 'noEmit' cannot be specified with option 'composite'."
// TS incremental build is not playing well with Babel projects
// { "path": "web" }
]
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants