Allows emitting buildInfo when --noEmit is specified #39122
Conversation
sheetalkamat
force-pushed
the
noEmitIncremental
branch
from
0c70dd4 to
e18dd33
Compare
| @@ -462,7 +462,6 @@ namespace ts { | |||
| { | |||
| name: "noEmit", | |||
| type: "boolean", | |||
| affectsEmit: true, | |||
There was a problem hiding this comment.
Personally, I find this surprising enough that I'd leave it present but commented out and with an explanation.
| @@ -1013,6 +1013,12 @@ namespace ts { | |||
| } | |||
| } | |||
|
|
|||
| function errorSkippedOn(key: keyof CompilerOptions, location: Node | undefined, message: DiagnosticMessage, arg0?: string | number, arg1?: string | number, arg2?: string | number, arg3?: string | number): Diagnostic { | |||
There was a problem hiding this comment.
I'm having trouble wrapping my head around what this does and would find an explanation helpful.
There was a problem hiding this comment.
location, message, arg0, ... are the existing error logging parameters.
key: keyof CompilerOptions is a typesafe way to assert that key, while a string, actually refers to a property in CompilerOptions. That way the string can safely be used as a property name of CompilerOptions in filterSemanticDiagnostics:
filter(diagnostics, d => !d.skippedOn || !options[d.skippedOn])
This keeps diagnostics that
- were not issued by
errorSkippedOn, so didn't setskippedOn
-OR- - do have
skippedOn, which is guaranteed to be the name of a property in compiler options, say "noEmit". For the "noEmit" example,!options[d.skippedOn]is equivalent to!options.noEmit.
This meta-programming JS would require an enum plus a switch-case conversion in C# I think. Or the meta-programming facilities there, though the result wouldn't be as typesafe as in Typescript.
| @@ -3675,6 +3678,11 @@ namespace ts { | |||
| return { diagnostics, sourceMaps: undefined, emittedFiles, emitSkipped: true }; | |||
| } | |||
|
|
|||
| /*@internal*/ | |||
| export function filterSemanticDiagnotics(diagnostic: readonly Diagnostic[], option: CompilerOptions): readonly Diagnostic[] { | |||
There was a problem hiding this comment.
should probably be named diagnostics and options
There was a problem hiding this comment.
There's also a typo in the function name.
This change emits buildinfo even if
noEmitis specifiedNow referencing composite project with
noEmitsetting is error instead of erroring on project itself.This allows to typecheck only run on composite projects just like any other project.
Also as part of this change, there were checker errors that were skipped if
noEmitis on. Instead now those errors are generated but filtered when someone asks for semanticDiagnostics instead. This allows to preserver the diagnostics across emit and noEmit builds and having to invalidate cache/emit files/make extra pass on the code to get those diagnosticsFixes #38440