Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node-based @deprecated checks #39323

Merged
merged 7 commits into from
Jul 2, 2020
Merged

Node-based @deprecated checks #39323

merged 7 commits into from
Jul 2, 2020

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jun 29, 2020 •
edited
Loading

Switch the checker to syntactic checks for @deprecated on declarations. This requires a bit more checking of declarations in the
checker at times, but it:

  1. Gets rid of work, and a symbol flag, in the binder.
  2. Skips work in the checker unless there is a @deprecated tag.
  3. Makes it fairly simple to only issue errors on particular signatures of overloaded functions.

Fixes #39212, alternative to #39221 -- and tests are based on #39221's.

Edit: This now fixes part of #39374; JSX elements, decorators and tagged template functions are all calls and were not being marked deprecated.

@sandersn
Node-based @deprecated checks
f419bb2 
Switch the checker to syntactic checks for `@deprecated` on
declarations. This requires a bit more checking of declarations in the
checker at times, but it

1. Gets rid of work, and a symbol flag, in the binder.
2. Skips work in the checker unless there is a `@deprecated` tag.
3. Makes it fairly simple to only issue errors on particular signatures
   of overloaded functions.
@sandersn
remove in-progress comment
8079ec2
@sandersn sandersn requested a review from Kingwl June 29, 2020 20:47
@sandersn
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 29, 2020 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 8079ec2. You can monitor the build here.

Update: The results are in!

@sandersn
Copy link
Member Author

sandersn commented Jun 29, 2020 •
edited
Loading

Note: isTypeDeclaration from #39221 is better and should be copied here. I think the tests from here have a few more cases than those in #39221 and should be copied there.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39323

Metric master 39323 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 343,972k (± 0.02%) 343,422k (± 0.02%) -551k (- 0.16%) 343,258k 343,609k
Parse Time 2.02s (± 0.53%) 2.01s (± 0.84%) -0.00s (- 0.20%) 1.97s 2.04s
Bind Time 0.82s (± 1.35%) 0.82s (± 0.79%) -0.01s (- 0.73%) 0.81s 0.84s
Check Time 4.74s (± 0.50%) 4.75s (± 0.62%) +0.01s (+ 0.21%) 4.67s 4.81s
Emit Time 5.19s (± 0.90%) 5.21s (± 0.68%) +0.02s (+ 0.35%) 5.12s 5.28s
Total Time 12.77s (± 0.46%) 12.79s (± 0.35%) +0.02s (+ 0.18%) 12.71s 12.89s
Monaco - node (v10.16.3, x64)
Memory used 339,078k (± 0.02%) 339,148k (± 0.02%) +70k (+ 0.02%) 339,015k 339,357k
Parse Time 1.59s (± 0.56%) 1.60s (± 0.57%) +0.00s (+ 0.25%) 1.57s 1.61s
Bind Time 0.72s (± 0.72%) 0.72s (± 0.51%) -0.00s (- 0.42%) 0.71s 0.72s
Check Time 4.89s (± 0.36%) 4.90s (± 0.67%) +0.01s (+ 0.12%) 4.83s 4.99s
Emit Time 2.76s (± 0.64%) 2.76s (± 0.48%) +0.00s (+ 0.00%) 2.74s 2.79s
Total Time 9.97s (± 0.35%) 9.98s (± 0.48%) +0.01s (+ 0.07%) 9.86s 10.11s
TFS - node (v10.16.3, x64)
Memory used 301,994k (± 0.01%) 301,996k (± 0.01%) +2k (+ 0.00%) 301,938k 302,083k
Parse Time 1.23s (± 0.48%) 1.22s (± 0.61%) -0.00s (- 0.24%) 1.21s 1.24s
Bind Time 0.67s (± 0.92%) 0.66s (± 1.52%) -0.01s (- 1.04%) 0.63s 0.68s
Check Time 4.39s (± 0.41%) 4.39s (± 0.73%) +0.00s (+ 0.00%) 4.34s 4.46s
Emit Time 2.91s (± 1.40%) 2.90s (± 1.02%) -0.01s (- 0.45%) 2.81s 2.94s
Total Time 9.20s (± 0.64%) 9.18s (± 0.48%) -0.02s (- 0.16%) 9.10s 9.29s
material-ui - node (v10.16.3, x64)
Memory used 459,348k (± 0.01%) 459,111k (± 0.01%) -238k (- 0.05%) 458,901k 459,292k
Parse Time 2.06s (± 0.36%) 2.05s (± 0.46%) -0.00s (- 0.15%) 2.04s 2.08s
Bind Time 0.66s (± 1.28%) 0.66s (± 1.22%) -0.00s (- 0.45%) 0.64s 0.67s
Check Time 13.04s (± 0.63%) 12.97s (± 1.03%) -0.07s (- 0.55%) 12.79s 13.46s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.76s (± 0.52%) 15.68s (± 0.87%) -0.08s (- 0.49%) 15.48s 16.17s
Angular - node (v12.1.0, x64)
Memory used 321,115k (± 0.02%) 320,665k (± 0.03%) -449k (- 0.14%) 320,506k 320,835k
Parse Time 2.01s (± 0.62%) 2.00s (± 0.36%) -0.01s (- 0.45%) 1.99s 2.02s
Bind Time 0.81s (± 0.58%) 0.80s (± 0.61%) -0.01s (- 0.74%) 0.79s 0.81s
Check Time 4.64s (± 0.34%) 4.63s (± 0.34%) -0.01s (- 0.30%) 4.59s 4.66s
Emit Time 5.37s (± 0.55%) 5.37s (± 0.81%) -0.00s (- 0.02%) 5.29s 5.47s
Total Time 12.83s (± 0.26%) 12.80s (± 0.44%) -0.03s (- 0.23%) 12.68s 12.93s
Monaco - node (v12.1.0, x64)
Memory used 321,525k (± 0.02%) 321,535k (± 0.01%) +10k (+ 0.00%) 321,458k 321,615k
Parse Time 1.56s (± 0.86%) 1.56s (± 1.13%) -0.00s (- 0.32%) 1.51s 1.60s
Bind Time 0.69s (± 1.66%) 0.69s (± 0.32%) -0.00s (- 0.58%) 0.68s 0.69s
Check Time 4.68s (± 0.50%) 4.71s (± 0.72%) +0.04s (+ 0.75%) 4.63s 4.78s
Emit Time 2.82s (± 0.68%) 2.83s (± 0.37%) +0.01s (+ 0.25%) 2.80s 2.85s
Total Time 9.76s (± 0.28%) 9.79s (± 0.40%) +0.03s (+ 0.33%) 9.70s 9.86s
TFS - node (v12.1.0, x64)
Memory used 286,490k (± 0.02%) 286,490k (± 0.02%) -0k (- 0.00%) 286,338k 286,641k
Parse Time 1.24s (± 0.88%) 1.24s (± 0.61%) +0.00s (+ 0.16%) 1.23s 1.26s
Bind Time 0.64s (± 1.04%) 0.64s (± 1.45%) -0.00s (- 0.78%) 0.62s 0.67s
Check Time 4.29s (± 0.50%) 4.30s (± 0.70%) +0.00s (+ 0.05%) 4.22s 4.34s
Emit Time 2.92s (± 1.22%) 2.93s (± 0.61%) +0.01s (+ 0.31%) 2.89s 2.97s
Total Time 9.10s (± 0.59%) 9.11s (± 0.47%) +0.01s (+ 0.13%) 9.01s 9.21s
material-ui - node (v12.1.0, x64)
Memory used 437,563k (± 0.06%) 437,406k (± 0.06%) -157k (- 0.04%) 436,447k 437,656k
Parse Time 2.03s (± 0.61%) 2.03s (± 0.17%) +0.00s (+ 0.15%) 2.03s 2.04s
Bind Time 0.64s (± 0.70%) 0.64s (± 0.93%) -0.00s (- 0.31%) 0.62s 0.65s
Check Time 11.72s (± 0.93%) 11.79s (± 0.70%) +0.07s (+ 0.57%) 11.60s 12.02s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.39s (± 0.81%) 14.46s (± 0.56%) +0.07s (+ 0.47%) 14.28s 14.69s
Angular - node (v8.9.0, x64)
Memory used 340,394k (± 0.02%) 340,019k (± 0.01%) -375k (- 0.11%) 339,927k 340,119k
Parse Time 2.56s (± 0.84%) 2.54s (± 0.88%) -0.01s (- 0.59%) 2.51s 2.60s
Bind Time 0.86s (± 1.03%) 0.85s (± 0.68%) -0.01s (- 1.39%) 0.84s 0.86s
Check Time 5.35s (± 0.44%) 5.36s (± 0.47%) +0.00s (+ 0.04%) 5.32s 5.43s
Emit Time 5.95s (± 1.37%) 5.99s (± 0.86%) +0.03s (+ 0.55%) 5.89s 6.10s
Total Time 14.73s (± 0.65%) 14.74s (± 0.58%) +0.01s (+ 0.06%) 14.61s 15.00s
Monaco - node (v8.9.0, x64)
Memory used 340,458k (± 0.01%) 340,444k (± 0.01%) -14k (- 0.00%) 340,383k 340,514k
Parse Time 1.88s (± 0.40%) 1.88s (± 0.47%) -0.00s (- 0.00%) 1.86s 1.91s
Bind Time 0.89s (± 0.63%) 0.89s (± 0.38%) -0.00s (- 0.11%) 0.88s 0.89s
Check Time 5.39s (± 0.46%) 5.41s (± 0.71%) +0.02s (+ 0.33%) 5.33s 5.49s
Emit Time 3.25s (± 0.69%) 3.23s (± 0.59%) -0.02s (- 0.65%) 3.20s 3.27s
Total Time 11.41s (± 0.39%) 11.41s (± 0.48%) -0.00s (- 0.02%) 11.29s 11.53s
TFS - node (v8.9.0, x64)
Memory used 303,733k (± 0.02%) 303,759k (± 0.02%) +26k (+ 0.01%) 303,655k 303,864k
Parse Time 1.56s (± 0.47%) 1.56s (± 0.97%) -0.00s (- 0.00%) 1.53s 1.60s
Bind Time 0.67s (± 0.88%) 0.67s (± 0.50%) -0.00s (- 0.59%) 0.66s 0.68s
Check Time 4.97s (± 1.59%) 5.03s (± 1.67%) +0.06s (+ 1.21%) 4.92s 5.21s
Emit Time 3.12s (± 2.77%) 3.09s (± 3.17%) -0.03s (- 1.02%) 2.89s 3.22s
Total Time 10.32s (± 0.50%) 10.35s (± 0.48%) +0.03s (+ 0.24%) 10.20s 10.42s
material-ui - node (v8.9.0, x64)
Memory used 463,627k (± 0.01%) 463,361k (± 0.01%) -266k (- 0.06%) 463,292k 463,551k
Parse Time 2.40s (± 0.39%) 2.40s (± 0.51%) +0.00s (+ 0.17%) 2.37s 2.43s
Bind Time 0.79s (± 1.15%) 0.78s (± 1.28%) -0.01s (- 1.14%) 0.76s 0.81s
Check Time 17.29s (± 1.03%) 17.27s (± 1.16%) -0.03s (- 0.15%) 16.91s 17.79s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.48s (± 0.88%) 20.45s (± 0.99%) -0.03s (- 0.15%) 20.09s 20.97s
Angular - node (v8.9.0, x86)
Memory used 195,312k (± 0.02%) 195,077k (± 0.02%) -235k (- 0.12%) 194,999k 195,130k
Parse Time 2.47s (± 1.05%) 2.45s (± 0.64%) -0.03s (- 1.05%) 2.41s 2.49s
Bind Time 1.00s (± 0.37%) 0.98s (± 0.63%) -0.01s (- 1.41%) 0.97s 0.99s
Check Time 4.81s (± 0.63%) 4.83s (± 0.59%) +0.02s (+ 0.50%) 4.75s 4.89s
Emit Time 5.96s (± 0.70%) 5.94s (± 1.10%) -0.03s (- 0.47%) 5.72s 6.05s
Total Time 14.24s (± 0.56%) 14.19s (± 0.63%) -0.05s (- 0.34%) 13.94s 14.38s
Monaco - node (v8.9.0, x86)
Memory used 193,434k (± 0.03%) 193,448k (± 0.03%) +15k (+ 0.01%) 193,331k 193,519k
Parse Time 1.92s (± 0.90%) 1.93s (± 1.19%) +0.02s (+ 0.83%) 1.90s 2.00s
Bind Time 0.70s (± 0.52%) 0.71s (± 0.87%) +0.00s (+ 0.71%) 0.70s 0.73s
Check Time 5.50s (± 0.56%) 5.51s (± 0.41%) +0.00s (+ 0.09%) 5.43s 5.54s
Emit Time 2.70s (± 0.37%) 2.67s (± 0.64%) -0.03s (- 1.22%) 2.63s 2.70s
Total Time 10.82s (± 0.34%) 10.82s (± 0.23%) -0.01s (- 0.07%) 10.76s 10.86s
TFS - node (v8.9.0, x86)
Memory used 173,686k (± 0.02%) 173,718k (± 0.03%) +31k (+ 0.02%) 173,591k 173,827k
Parse Time 1.60s (± 1.55%) 1.58s (± 0.38%) -0.02s (- 1.31%) 1.57s 1.60s
Bind Time 0.64s (± 0.57%) 0.64s (± 0.87%) +0.00s (+ 0.31%) 0.63s 0.65s
Check Time 4.68s (± 0.78%) 4.65s (± 0.58%) -0.03s (- 0.56%) 4.60s 4.69s
Emit Time 2.82s (± 0.94%) 2.79s (± 1.18%) -0.03s (- 1.03%) 2.71s 2.88s
Total Time 9.74s (± 0.47%) 9.67s (± 0.52%) -0.07s (- 0.76%) 9.55s 9.80s
material-ui - node (v8.9.0, x86)
Memory used 262,573k (± 0.02%) 262,419k (± 0.02%) -153k (- 0.06%) 262,343k 262,535k
Parse Time 2.47s (± 0.53%) 2.45s (± 0.50%) -0.01s (- 0.57%) 2.42s 2.47s
Bind Time 0.68s (± 1.10%) 0.67s (± 1.86%) -0.00s (- 0.44%) 0.65s 0.71s
Check Time 15.71s (± 0.63%) 15.68s (± 0.51%) -0.04s (- 0.22%) 15.46s 15.82s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.85s (± 0.55%) 18.81s (± 0.47%) -0.05s (- 0.25%) 18.58s 18.95s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39323 10
Baseline master 10

@Kingwl
Copy link
Contributor

Kingwl commented Jun 30, 2020

@typescript-bot pack this.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2020 •
edited
Loading

Heya @Kingwl, I've started to run the tarball bundle task on this PR at 4b8c75b. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 30, 2020 •
edited
Loading

Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/78205/artifacts?artifactName=tgz&fileId=98EF0A452AF3E561A3301E65146CDDDCAA10B21D1DAAAF0D81E767BF9F36BD7602&fileName=/typescript-4.0.0-insiders.20200630.tgz"
    }
}

and then running npm install.

There is also a playground for this build.

Kingwl
Kingwl approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looks pretty good and simple and faster.

src/compiler/checker.ts Outdated Show resolved Hide resolved
src/compiler/checker.ts Outdated Show resolved Hide resolved
DanielRosenwasser
DanielRosenwasser reviewed Jun 30, 2020
View reviewed changes
src/compiler/checker.ts Show resolved Hide resolved
src/compiler/checker.ts Outdated Show resolved Hide resolved
@Kingwl Kingwl mentioned this pull request Jul 2, 2020
Closed
sandersn
sandersn commented Jul 2, 2020
View reviewed changes
Copy link
Member Author

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I couldn't figure out how to reference the constructor symbol, so I left it out.
  2. isCallLikeExpression also supports JSX, tagged templates, and Decorators, so I added tests for those.

(github isn't letting me reply to other comments)

src/compiler/checker.ts Show resolved Hide resolved
@sandersn
Copy link
Member Author

sandersn commented Jul 2, 2020

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2020 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 9eb774b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39323

Metric master 39323 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,007k (± 0.02%) 343,480k (± 0.02%) -527k (- 0.15%) 343,369k 343,637k
Parse Time 2.00s (± 0.60%) 1.99s (± 0.51%) -0.01s (- 0.50%) 1.97s 2.02s
Bind Time 0.82s (± 0.46%) 0.81s (± 0.90%) -0.00s (- 0.37%) 0.80s 0.83s
Check Time 4.71s (± 0.48%) 4.73s (± 0.51%) +0.02s (+ 0.36%) 4.68s 4.78s
Emit Time 5.15s (± 0.63%) 5.17s (± 0.66%) +0.02s (+ 0.47%) 5.11s 5.25s
Total Time 12.68s (± 0.44%) 12.71s (± 0.40%) +0.03s (+ 0.21%) 12.61s 12.82s
Monaco - node (v10.16.3, x64)
Memory used 339,074k (± 0.02%) 339,051k (± 0.03%) -23k (- 0.01%) 338,864k 339,254k
Parse Time 1.57s (± 0.64%) 1.58s (± 0.42%) +0.01s (+ 0.51%) 1.57s 1.60s
Bind Time 0.71s (± 0.91%) 0.71s (± 0.73%) +0.00s (+ 0.14%) 0.70s 0.72s
Check Time 4.85s (± 0.57%) 4.89s (± 1.00%) +0.04s (+ 0.82%) 4.80s 5.00s
Emit Time 2.76s (± 1.28%) 2.76s (± 0.72%) +0.00s (+ 0.15%) 2.72s 2.80s
Total Time 9.89s (± 0.52%) 9.94s (± 0.58%) +0.05s (+ 0.54%) 9.82s 10.07s
TFS - node (v10.16.3, x64)
Memory used 302,025k (± 0.03%) 302,008k (± 0.01%) -17k (- 0.01%) 301,897k 302,093k
Parse Time 1.22s (± 0.67%) 1.21s (± 0.62%) -0.01s (- 0.57%) 1.20s 1.23s
Bind Time 0.67s (± 0.86%) 0.67s (± 1.34%) -0.00s (- 0.75%) 0.64s 0.69s
Check Time 4.37s (± 0.42%) 4.39s (± 0.50%) +0.02s (+ 0.55%) 4.33s 4.43s
Emit Time 2.89s (± 1.28%) 2.92s (± 0.78%) +0.03s (+ 0.93%) 2.86s 2.96s
Total Time 9.15s (± 0.34%) 9.19s (± 0.43%) +0.04s (+ 0.46%) 9.11s 9.26s
material-ui - node (v10.16.3, x64)
Memory used 459,390k (± 0.01%) 459,129k (± 0.01%) -261k (- 0.06%) 458,997k 459,215k
Parse Time 2.04s (± 0.37%) 2.04s (± 0.38%) -0.01s (- 0.29%) 2.02s 2.06s
Bind Time 0.65s (± 1.59%) 0.66s (± 0.93%) +0.01s (+ 1.38%) 0.64s 0.67s
Check Time 12.94s (± 0.52%) 12.87s (± 0.78%) -0.07s (- 0.57%) 12.76s 13.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.43%) 15.57s (± 0.69%) -0.07s (- 0.48%) 15.45s 15.86s
Angular - node (v12.1.0, x64)
Memory used 321,070k (± 0.03%) 320,605k (± 0.02%) -465k (- 0.14%) 320,443k 320,772k
Parse Time 1.99s (± 0.42%) 2.00s (± 0.63%) +0.01s (+ 0.40%) 1.98s 2.03s
Bind Time 0.81s (± 0.82%) 0.80s (± 1.00%) -0.01s (- 0.99%) 0.79s 0.82s
Check Time 4.60s (± 0.46%) 4.61s (± 0.44%) +0.01s (+ 0.33%) 4.57s 4.65s
Emit Time 5.33s (± 0.52%) 5.38s (± 0.75%) +0.05s (+ 0.94%) 5.28s 5.47s
Total Time 12.73s (± 0.29%) 12.79s (± 0.33%) +0.06s (+ 0.50%) 12.71s 12.88s
Monaco - node (v12.1.0, x64)
Memory used 321,512k (± 0.02%) 321,513k (± 0.02%) +1k (+ 0.00%) 321,398k 321,594k
Parse Time 1.54s (± 0.72%) 1.56s (± 0.94%) +0.01s (+ 0.71%) 1.52s 1.59s
Bind Time 0.69s (± 0.58%) 0.69s (± 0.72%) -0.00s (- 0.44%) 0.68s 0.70s
Check Time 4.65s (± 0.49%) 4.66s (± 0.47%) +0.02s (+ 0.37%) 4.63s 4.73s
Emit Time 2.81s (± 0.65%) 2.83s (± 0.89%) +0.02s (+ 0.53%) 2.78s 2.90s
Total Time 9.69s (± 0.40%) 9.73s (± 0.39%) +0.04s (+ 0.43%) 9.65s 9.84s
TFS - node (v12.1.0, x64)
Memory used 286,472k (± 0.03%) 286,529k (± 0.02%) +57k (+ 0.02%) 286,412k 286,644k
Parse Time 1.23s (± 0.71%) 1.24s (± 1.19%) +0.01s (+ 0.65%) 1.21s 1.27s
Bind Time 0.64s (± 1.21%) 0.64s (± 1.16%) +0.00s (+ 0.16%) 0.63s 0.66s
Check Time 4.29s (± 0.57%) 4.29s (± 0.46%) +0.00s (+ 0.09%) 4.23s 4.33s
Emit Time 2.92s (± 0.70%) 2.91s (± 0.59%) -0.01s (- 0.21%) 2.88s 2.94s
Total Time 9.07s (± 0.39%) 9.08s (± 0.26%) +0.01s (+ 0.07%) 9.03s 9.12s
material-ui - node (v12.1.0, x64)
Memory used 437,734k (± 0.01%) 437,383k (± 0.05%) -351k (- 0.08%) 436,500k 437,595k
Parse Time 2.02s (± 0.46%) 2.03s (± 0.46%) +0.01s (+ 0.30%) 2.01s 2.06s
Bind Time 0.63s (± 0.94%) 0.63s (± 1.11%) -0.00s (- 0.47%) 0.61s 0.64s
Check Time 11.61s (± 0.65%) 11.64s (± 1.06%) +0.03s (+ 0.22%) 11.42s 11.92s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.27s (± 0.55%) 14.30s (± 0.87%) +0.03s (+ 0.21%) 14.08s 14.57s
Angular - node (v8.9.0, x64)
Memory used 340,442k (± 0.02%) 340,076k (± 0.02%) -366k (- 0.11%) 339,964k 340,208k
Parse Time 2.53s (± 0.33%) 2.53s (± 0.75%) +0.00s (+ 0.20%) 2.50s 2.59s
Bind Time 0.86s (± 0.69%) 0.85s (± 0.94%) -0.01s (- 0.93%) 0.83s 0.86s
Check Time 5.36s (± 0.78%) 5.37s (± 0.70%) +0.00s (+ 0.07%) 5.29s 5.45s
Emit Time 5.92s (± 1.14%) 5.90s (± 1.83%) -0.02s (- 0.41%) 5.67s 6.10s
Total Time 14.67s (± 0.57%) 14.64s (± 0.95%) -0.02s (- 0.16%) 14.35s 14.93s
Monaco - node (v8.9.0, x64)
Memory used 340,431k (± 0.02%) 340,462k (± 0.01%) +30k (+ 0.01%) 340,336k 340,547k
Parse Time 1.87s (± 0.54%) 1.87s (± 0.32%) +0.00s (+ 0.05%) 1.86s 1.88s
Bind Time 0.88s (± 0.25%) 0.88s (± 0.59%) +0.00s (+ 0.23%) 0.87s 0.89s
Check Time 5.36s (± 0.69%) 5.40s (± 0.61%) +0.04s (+ 0.80%) 5.33s 5.47s
Emit Time 3.21s (± 0.65%) 3.21s (± 0.82%) -0.01s (- 0.22%) 3.16s 3.29s
Total Time 11.32s (± 0.45%) 11.36s (± 0.43%) +0.04s (+ 0.31%) 11.24s 11.47s
TFS - node (v8.9.0, x64)
Memory used 303,759k (± 0.02%) 303,773k (± 0.02%) +15k (+ 0.00%) 303,644k 303,911k
Parse Time 1.55s (± 0.65%) 1.54s (± 0.34%) -0.01s (- 0.39%) 1.53s 1.55s
Bind Time 0.67s (± 0.50%) 0.67s (± 0.92%) -0.00s (- 0.15%) 0.65s 0.68s
Check Time 4.92s (± 1.49%) 5.03s (± 1.58%) +0.11s (+ 2.28%) 4.87s 5.17s
Emit Time 3.10s (± 2.51%) 3.04s (± 2.88%) -0.06s (- 1.84%) 2.88s 3.22s
Total Time 10.24s (± 0.42%) 10.29s (± 0.53%) +0.05s (+ 0.47%) 10.18s 10.39s
material-ui - node (v8.9.0, x64)
Memory used 463,661k (± 0.02%) 463,409k (± 0.02%) -252k (- 0.05%) 463,291k 463,722k
Parse Time 2.39s (± 0.51%) 2.38s (± 0.40%) -0.01s (- 0.38%) 2.36s 2.40s
Bind Time 0.78s (± 1.56%) 0.76s (± 1.17%) -0.01s (- 1.42%) 0.75s 0.79s
Check Time 17.16s (± 0.88%) 17.18s (± 0.63%) +0.02s (+ 0.13%) 16.86s 17.39s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.32s (± 0.71%) 20.32s (± 0.57%) +0.00s (+ 0.00%) 19.97s 20.55s
Angular - node (v8.9.0, x86)
Memory used 195,313k (± 0.03%) 195,048k (± 0.03%) -264k (- 0.14%) 194,923k 195,182k
Parse Time 2.47s (± 1.39%) 2.47s (± 0.87%) +0.00s (+ 0.08%) 2.43s 2.52s
Bind Time 0.99s (± 1.03%) 0.99s (± 1.13%) -0.01s (- 0.61%) 0.96s 1.02s
Check Time 4.82s (± 0.49%) 4.79s (± 0.48%) -0.03s (- 0.62%) 4.75s 4.84s
Emit Time 5.95s (± 0.80%) 5.96s (± 1.25%) +0.01s (+ 0.12%) 5.82s 6.19s
Total Time 14.23s (± 0.59%) 14.21s (± 0.60%) -0.03s (- 0.20%) 14.04s 14.41s
Monaco - node (v8.9.0, x86)
Memory used 193,467k (± 0.02%) 193,466k (± 0.02%) -1k (- 0.00%) 193,356k 193,542k
Parse Time 1.92s (± 0.53%) 1.91s (± 0.80%) -0.01s (- 0.47%) 1.89s 1.96s
Bind Time 0.70s (± 0.49%) 0.69s (± 0.53%) -0.00s (- 0.29%) 0.69s 0.70s
Check Time 5.47s (± 0.28%) 5.48s (± 1.53%) +0.01s (+ 0.20%) 5.17s 5.60s
Emit Time 2.68s (± 1.09%) 2.72s (± 2.56%) +0.04s (+ 1.42%) 2.62s 2.98s
Total Time 10.76s (± 0.29%) 10.81s (± 0.44%) +0.04s (+ 0.40%) 10.72s 10.91s
TFS - node (v8.9.0, x86)
Memory used 173,716k (± 0.02%) 173,708k (± 0.02%) -9k (- 0.00%) 173,646k 173,800k
Parse Time 1.58s (± 0.76%) 1.58s (± 0.94%) 0.00s ( 0.00%) 1.56s 1.63s
Bind Time 0.64s (± 1.20%) 0.64s (± 0.91%) +0.00s (+ 0.31%) 0.63s 0.65s
Check Time 4.64s (± 0.76%) 4.66s (± 0.56%) +0.02s (+ 0.39%) 4.58s 4.72s
Emit Time 2.78s (± 1.37%) 2.82s (± 1.54%) +0.03s (+ 1.22%) 2.71s 2.90s
Total Time 9.65s (± 0.55%) 9.70s (± 0.67%) +0.05s (+ 0.52%) 9.54s 9.80s
material-ui - node (v8.9.0, x86)
Memory used 262,525k (± 0.02%) 262,426k (± 0.01%) -99k (- 0.04%) 262,321k 262,477k
Parse Time 2.46s (± 0.48%) 2.46s (± 1.02%) -0.00s (- 0.12%) 2.42s 2.55s
Bind Time 0.67s (± 1.35%) 0.67s (± 1.25%) -0.01s (- 0.89%) 0.65s 0.68s
Check Time 15.69s (± 0.64%) 15.72s (± 0.73%) +0.03s (+ 0.20%) 15.50s 16.03s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.82s (± 0.57%) 18.84s (± 0.68%) +0.02s (+ 0.13%) 18.59s 19.13s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39323 10
Baseline master 10

@sandersn
Copy link
Member Author

sandersn commented Jul 2, 2020

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2020 •
edited
Loading

Heya @sandersn, I've started to run the perf test suite on this PR at 9eb774b. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39323

Metric master 39323 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,007k (± 0.02%) 343,376k (± 0.02%) -632k (- 0.18%) 343,253k 343,512k
Parse Time 2.00s (± 0.60%) 2.00s (± 0.72%) -0.01s (- 0.35%) 1.97s 2.03s
Bind Time 0.82s (± 0.46%) 0.81s (± 0.93%) -0.00s (- 0.12%) 0.80s 0.84s
Check Time 4.71s (± 0.48%) 4.72s (± 0.47%) +0.01s (+ 0.19%) 4.68s 4.78s
Emit Time 5.15s (± 0.63%) 5.18s (± 0.83%) +0.03s (+ 0.64%) 5.11s 5.27s
Total Time 12.68s (± 0.44%) 12.72s (± 0.42%) +0.04s (+ 0.29%) 12.61s 12.84s
Monaco - node (v10.16.3, x64)
Memory used 339,074k (± 0.02%) 339,166k (± 0.02%) +92k (+ 0.03%) 339,040k 339,330k
Parse Time 1.57s (± 0.64%) 1.57s (± 0.60%) -0.00s (- 0.06%) 1.56s 1.60s
Bind Time 0.71s (± 0.91%) 0.71s (± 0.66%) +0.00s (+ 0.28%) 0.70s 0.72s
Check Time 4.85s (± 0.57%) 4.86s (± 0.53%) +0.01s (+ 0.14%) 4.82s 4.93s
Emit Time 2.76s (± 1.28%) 2.75s (± 0.40%) -0.01s (- 0.22%) 2.73s 2.77s
Total Time 9.89s (± 0.52%) 9.89s (± 0.35%) +0.00s (+ 0.01%) 9.81s 9.97s
TFS - node (v10.16.3, x64)
Memory used 302,025k (± 0.03%) 301,998k (± 0.03%) -26k (- 0.01%) 301,799k 302,167k
Parse Time 1.22s (± 0.67%) 1.22s (± 0.56%) -0.00s (- 0.33%) 1.20s 1.23s
Bind Time 0.67s (± 0.86%) 0.66s (± 1.01%) -0.01s (- 1.04%) 0.64s 0.67s
Check Time 4.37s (± 0.42%) 4.39s (± 0.40%) +0.02s (+ 0.50%) 4.35s 4.43s
Emit Time 2.89s (± 1.28%) 2.90s (± 1.05%) +0.01s (+ 0.38%) 2.80s 2.95s
Total Time 9.15s (± 0.34%) 9.17s (± 0.46%) +0.02s (+ 0.21%) 9.03s 9.26s
material-ui - node (v10.16.3, x64)
Memory used 459,390k (± 0.01%) 459,061k (± 0.01%) -328k (- 0.07%) 458,961k 459,207k
Parse Time 2.04s (± 0.37%) 2.04s (± 0.73%) -0.00s (- 0.05%) 2.02s 2.09s
Bind Time 0.65s (± 1.59%) 0.65s (± 2.14%) -0.00s (- 0.46%) 0.62s 0.67s
Check Time 12.94s (± 0.52%) 12.94s (± 0.64%) +0.00s (+ 0.01%) 12.81s 13.08s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.64s (± 0.43%) 15.64s (± 0.56%) -0.01s (- 0.04%) 15.50s 15.79s
Angular - node (v12.1.0, x64)
Memory used 321,070k (± 0.03%) 320,690k (± 0.02%) -380k (- 0.12%) 320,468k 320,854k
Parse Time 1.99s (± 0.42%) 1.98s (± 0.67%) -0.01s (- 0.45%) 1.96s 2.01s
Bind Time 0.81s (± 0.82%) 0.80s (± 0.50%) -0.01s (- 1.36%) 0.79s 0.81s
Check Time 4.60s (± 0.46%) 4.62s (± 0.60%) +0.02s (+ 0.41%) 4.56s 4.68s
Emit Time 5.33s (± 0.52%) 5.36s (± 0.66%) +0.03s (+ 0.47%) 5.30s 5.43s
Total Time 12.73s (± 0.29%) 12.76s (± 0.46%) +0.03s (+ 0.20%) 12.68s 12.88s
Monaco - node (v12.1.0, x64)
Memory used 321,512k (± 0.02%) 321,540k (± 0.01%) +28k (+ 0.01%) 321,433k 321,645k
Parse Time 1.54s (± 0.72%) 1.54s (± 0.84%) +0.00s (+ 0.06%) 1.52s 1.57s
Bind Time 0.69s (± 0.58%) 0.68s (± 0.70%) -0.01s (- 0.87%) 0.68s 0.70s
Check Time 4.65s (± 0.49%) 4.66s (± 0.28%) +0.01s (+ 0.32%) 4.64s 4.69s
Emit Time 2.81s (± 0.65%) 2.80s (± 0.75%) -0.02s (- 0.57%) 2.75s 2.84s
Total Time 9.69s (± 0.40%) 9.69s (± 0.24%) -0.00s (- 0.02%) 9.62s 9.72s
TFS - node (v12.1.0, x64)
Memory used 286,472k (± 0.03%) 286,526k (± 0.02%) +54k (+ 0.02%) 286,384k 286,668k
Parse Time 1.23s (± 0.71%) 1.24s (± 0.98%) +0.01s (+ 0.41%) 1.21s 1.27s
Bind Time 0.64s (± 1.21%) 0.64s (± 0.93%) -0.00s (- 0.47%) 0.63s 0.65s
Check Time 4.29s (± 0.57%) 4.29s (± 0.57%) +0.01s (+ 0.19%) 4.22s 4.34s
Emit Time 2.92s (± 0.70%) 2.93s (± 0.99%) +0.01s (+ 0.41%) 2.88s 2.99s
Total Time 9.07s (± 0.39%) 9.09s (± 0.45%) +0.02s (+ 0.23%) 9.03s 9.18s
material-ui - node (v12.1.0, x64)
Memory used 437,734k (± 0.01%) 437,292k (± 0.07%) -441k (- 0.10%) 436,419k 437,609k
Parse Time 2.02s (± 0.46%) 2.03s (± 0.66%) +0.01s (+ 0.25%) 2.00s 2.06s
Bind Time 0.63s (± 0.94%) 0.63s (± 1.48%) -0.01s (- 0.95%) 0.61s 0.64s
Check Time 11.61s (± 0.65%) 11.67s (± 1.22%) +0.06s (+ 0.48%) 11.40s 12.04s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.27s (± 0.55%) 14.33s (± 1.09%) +0.05s (+ 0.39%) 14.05s 14.71s
Angular - node (v8.9.0, x64)
Memory used 340,442k (± 0.02%) 340,082k (± 0.02%) -360k (- 0.11%) 340,000k 340,261k
Parse Time 2.53s (± 0.33%) 2.53s (± 0.87%) +0.00s (+ 0.20%) 2.50s 2.59s
Bind Time 0.86s (± 0.69%) 0.84s (± 0.56%) -0.01s (- 1.52%) 0.84s 0.86s
Check Time 5.36s (± 0.78%) 5.36s (± 0.84%) -0.00s (- 0.09%) 5.28s 5.46s
Emit Time 5.92s (± 1.14%) 5.94s (± 1.41%) +0.01s (+ 0.25%) 5.75s 6.10s
Total Time 14.67s (± 0.57%) 14.67s (± 0.59%) +0.00s (+ 0.03%) 14.47s 14.87s
Monaco - node (v8.9.0, x64)
Memory used 340,431k (± 0.02%) 340,472k (± 0.02%) +40k (+ 0.01%) 340,295k 340,547k
Parse Time 1.87s (± 0.54%) 1.87s (± 0.64%) -0.00s (- 0.21%) 1.85s 1.91s
Bind Time 0.88s (± 0.25%) 0.88s (± 0.77%) +0.01s (+ 0.57%) 0.87s 0.90s
Check Time 5.36s (± 0.69%) 5.36s (± 0.76%) +0.00s (+ 0.04%) 5.28s 5.45s
Emit Time 3.21s (± 0.65%) 3.21s (± 0.70%) -0.00s (- 0.06%) 3.17s 3.29s
Total Time 11.32s (± 0.45%) 11.32s (± 0.42%) -0.00s (- 0.04%) 11.25s 11.43s
TFS - node (v8.9.0, x64)
Memory used 303,759k (± 0.02%) 303,805k (± 0.02%) +47k (+ 0.02%) 303,707k 303,927k
Parse Time 1.55s (± 0.65%) 1.54s (± 0.40%) -0.01s (- 0.52%) 1.53s 1.55s
Bind Time 0.67s (± 0.50%) 0.67s (± 0.71%) -0.00s (- 0.45%) 0.66s 0.68s
Check Time 4.92s (± 1.49%) 4.98s (± 1.72%) +0.06s (+ 1.22%) 4.86s 5.16s
Emit Time 3.10s (± 2.51%) 3.06s (± 2.32%) -0.04s (- 1.26%) 2.92s 3.17s
Total Time 10.24s (± 0.42%) 10.25s (± 0.37%) +0.01s (+ 0.08%) 10.16s 10.34s
material-ui - node (v8.9.0, x64)
Memory used 463,661k (± 0.02%) 463,334k (± 0.01%) -327k (- 0.07%) 463,161k 463,458k
Parse Time 2.39s (± 0.51%) 2.38s (± 0.41%) -0.01s (- 0.29%) 2.36s 2.40s
Bind Time 0.78s (± 1.56%) 0.77s (± 1.24%) -0.01s (- 1.16%) 0.74s 0.79s
Check Time 17.16s (± 0.88%) 17.25s (± 0.62%) +0.09s (+ 0.52%) 17.01s 17.56s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.32s (± 0.71%) 20.39s (± 0.52%) +0.07s (+ 0.34%) 20.16s 20.71s
Angular - node (v8.9.0, x86)
Memory used 195,313k (± 0.03%) 195,104k (± 0.03%) -208k (- 0.11%) 194,964k 195,240k
Parse Time 2.47s (± 1.39%) 2.45s (± 0.43%) -0.02s (- 0.65%) 2.43s 2.48s
Bind Time 0.99s (± 1.03%) 0.98s (± 0.97%) -0.01s (- 0.61%) 0.97s 1.01s
Check Time 4.82s (± 0.49%) 4.82s (± 0.58%) -0.00s (- 0.02%) 4.78s 4.91s
Emit Time 5.95s (± 0.80%) 5.90s (± 0.65%) -0.05s (- 0.87%) 5.80s 5.96s
Total Time 14.23s (± 0.59%) 14.16s (± 0.31%) -0.08s (- 0.54%) 14.07s 14.24s
Monaco - node (v8.9.0, x86)
Memory used 193,467k (± 0.02%) 193,433k (± 0.02%) -33k (- 0.02%) 193,365k 193,529k
Parse Time 1.92s (± 0.53%) 1.90s (± 0.55%) -0.01s (- 0.68%) 1.89s 1.94s
Bind Time 0.70s (± 0.49%) 0.70s (± 0.71%) -0.00s (- 0.14%) 0.69s 0.71s
Check Time 5.47s (± 0.28%) 5.48s (± 0.58%) +0.02s (+ 0.27%) 5.40s 5.54s
Emit Time 2.68s (± 1.09%) 2.67s (± 0.53%) -0.02s (- 0.63%) 2.64s 2.70s
Total Time 10.76s (± 0.29%) 10.75s (± 0.40%) -0.01s (- 0.12%) 10.68s 10.83s
TFS - node (v8.9.0, x86)
Memory used 173,716k (± 0.02%) 173,723k (± 0.03%) +7k (+ 0.00%) 173,626k 173,859k
Parse Time 1.58s (± 0.76%) 1.59s (± 1.11%) +0.01s (+ 0.32%) 1.56s 1.64s
Bind Time 0.64s (± 1.20%) 0.64s (± 1.19%) +0.00s (+ 0.16%) 0.63s 0.66s
Check Time 4.64s (± 0.76%) 4.62s (± 0.51%) -0.02s (- 0.37%) 4.57s 4.68s
Emit Time 2.78s (± 1.37%) 2.78s (± 0.61%) -0.00s (- 0.07%) 2.74s 2.81s
Total Time 9.65s (± 0.55%) 9.63s (± 0.46%) -0.02s (- 0.19%) 9.53s 9.72s
material-ui - node (v8.9.0, x86)
Memory used 262,525k (± 0.02%) 262,415k (± 0.02%) -110k (- 0.04%) 262,319k 262,567k
Parse Time 2.46s (± 0.48%) 2.43s (± 0.74%) -0.02s (- 0.98%) 2.40s 2.48s
Bind Time 0.67s (± 1.35%) 0.67s (± 1.43%) -0.00s (- 0.75%) 0.65s 0.69s
Check Time 15.69s (± 0.64%) 15.71s (± 0.90%) +0.02s (+ 0.10%) 15.47s 16.04s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.82s (± 0.57%) 18.81s (± 0.78%) -0.01s (- 0.05%) 18.56s 19.18s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39323 10
Baseline master 10

@sandersn
Copy link
Member Author

sandersn commented Jul 2, 2020

Overall, there's still a good bit of variation in our perf tests. But the perf on this is still pretty good even after supporting JSX et al. I'm going to merge this since I've addressed all the comments on it and in unblocks #39388.

@sandersn sandersn merged commit 93ccc17 into master Jul 2, 2020
@sandersn sandersn deleted the node-based-deprecated-checks branch July 2, 2020 21:10
@sandersn sandersn mentioned this pull request Jul 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@Kingwl Kingwl Kingwl approved these changes

@elibarzilay elibarzilay Awaiting requested review from elibarzilay

Assignees

@sandersn sandersn

Labels
Author: Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

document.createElement always marked deprecated
4 participants
@sandersn @typescript-bot @Kingwl @DanielRosenwasser