Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check combined node flag for deprecated #39388

Closed
wants to merge 1 commit into from
Closed

Check combined node flag for deprecated #39388

wants to merge 1 commit into from

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jul 2, 2020 •
edited
Loading

Fixes a part of #39374

Related: #39323

@Kingwl Kingwl changed the base branch from master to node-based-deprecated-checks July 2, 2020 17:22
@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 2, 2020

@typescript-bot perf test.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 2, 2020 •
edited
Loading

Heya @Kingwl, I've started to run the perf test suite on this PR at 57b28d2. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@Kingwl
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..39388

Metric master 39388 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 344,003k (± 0.02%) 343,398k (± 0.03%) -605k (- 0.18%) 343,209k 343,634k
Parse Time 2.00s (± 0.58%) 2.02s (± 0.68%) +0.01s (+ 0.60%) 1.99s 2.05s
Bind Time 0.82s (± 0.41%) 0.82s (± 0.83%) -0.00s (- 0.49%) 0.81s 0.84s
Check Time 4.72s (± 0.32%) 4.77s (± 0.47%) +0.06s (+ 1.23%) 4.73s 4.82s
Emit Time 5.17s (± 0.39%) 5.22s (± 0.60%) +0.05s (+ 0.97%) 5.16s 5.29s
Total Time 12.71s (± 0.24%) 12.83s (± 0.42%) +0.12s (+ 0.91%) 12.71s 12.94s
Monaco - node (v10.16.3, x64)
Memory used 339,106k (± 0.02%) 339,061k (± 0.02%) -45k (- 0.01%) 338,807k 339,151k
Parse Time 1.58s (± 0.64%) 1.58s (± 0.83%) +0.00s (+ 0.25%) 1.55s 1.61s
Bind Time 0.71s (± 0.63%) 0.71s (± 1.03%) -0.00s (- 0.56%) 0.69s 0.72s
Check Time 4.86s (± 0.50%) 4.90s (± 0.50%) +0.05s (+ 0.95%) 4.84s 4.96s
Emit Time 2.77s (± 0.66%) 2.76s (± 1.02%) -0.00s (- 0.18%) 2.73s 2.84s
Total Time 9.91s (± 0.40%) 9.96s (± 0.64%) +0.04s (+ 0.45%) 9.83s 10.12s
TFS - node (v10.16.3, x64)
Memory used 301,981k (± 0.03%) 301,956k (± 0.01%) -26k (- 0.01%) 301,892k 302,041k
Parse Time 1.21s (± 0.75%) 1.22s (± 0.60%) +0.01s (+ 0.74%) 1.20s 1.23s
Bind Time 0.66s (± 1.28%) 0.67s (± 0.87%) +0.01s (+ 0.91%) 0.66s 0.68s
Check Time 4.40s (± 0.53%) 4.43s (± 0.44%) +0.03s (+ 0.73%) 4.40s 4.49s
Emit Time 2.88s (± 1.22%) 2.91s (± 0.65%) +0.04s (+ 1.32%) 2.87s 2.96s
Total Time 9.14s (± 0.64%) 9.23s (± 0.33%) +0.09s (+ 0.96%) 9.18s 9.30s
material-ui - node (v10.16.3, x64)
Memory used 459,384k (± 0.01%) 459,051k (± 0.02%) -334k (- 0.07%) 458,903k 459,213k
Parse Time 2.05s (± 0.52%) 2.04s (± 0.29%) -0.00s (- 0.00%) 2.04s 2.06s
Bind Time 0.66s (± 1.28%) 0.65s (± 1.59%) -0.01s (- 1.06%) 0.63s 0.67s
Check Time 12.80s (± 0.48%) 12.94s (± 0.74%) +0.14s (+ 1.12%) 12.72s 13.14s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.50s (± 0.44%) 15.64s (± 0.64%) +0.14s (+ 0.88%) 15.39s 15.83s
Angular - node (v12.1.0, x64)
Memory used 321,096k (± 0.03%) 320,650k (± 0.03%) -446k (- 0.14%) 320,515k 320,829k
Parse Time 1.99s (± 0.68%) 1.99s (± 0.45%) +0.01s (+ 0.35%) 1.97s 2.01s
Bind Time 0.80s (± 0.85%) 0.80s (± 1.11%) 0.00s ( 0.00%) 0.79s 0.83s
Check Time 4.60s (± 0.47%) 4.68s (± 0.36%) +0.07s (+ 1.54%) 4.63s 4.72s
Emit Time 5.34s (± 0.56%) 5.39s (± 0.72%) +0.06s (+ 1.09%) 5.32s 5.49s
Total Time 12.73s (± 0.37%) 12.87s (± 0.37%) +0.13s (+ 1.04%) 12.78s 12.97s
Monaco - node (v12.1.0, x64)
Memory used 321,518k (± 0.02%) 321,533k (± 0.02%) +16k (+ 0.00%) 321,403k 321,608k
Parse Time 1.55s (± 0.83%) 1.55s (± 0.69%) -0.00s (- 0.19%) 1.52s 1.57s
Bind Time 0.69s (± 0.84%) 0.69s (± 0.69%) 0.00s ( 0.00%) 0.68s 0.70s
Check Time 4.65s (± 0.54%) 4.68s (± 0.41%) +0.04s (+ 0.75%) 4.64s 4.72s
Emit Time 2.80s (± 0.61%) 2.79s (± 1.04%) -0.00s (- 0.07%) 2.75s 2.88s
Total Time 9.68s (± 0.38%) 9.71s (± 0.47%) +0.03s (+ 0.30%) 9.61s 9.83s
TFS - node (v12.1.0, x64)
Memory used 286,487k (± 0.02%) 286,480k (± 0.03%) -7k (- 0.00%) 286,335k 286,727k
Parse Time 1.23s (± 0.61%) 1.23s (± 0.69%) +0.00s (+ 0.16%) 1.20s 1.25s
Bind Time 0.64s (± 1.20%) 0.64s (± 1.04%) +0.01s (+ 1.26%) 0.63s 0.66s
Check Time 4.26s (± 0.51%) 4.32s (± 0.70%) +0.06s (+ 1.34%) 4.27s 4.39s
Emit Time 2.91s (± 0.96%) 2.92s (± 1.08%) +0.01s (+ 0.41%) 2.86s 2.99s
Total Time 9.04s (± 0.45%) 9.11s (± 0.52%) +0.08s (+ 0.87%) 9.01s 9.21s
material-ui - node (v12.1.0, x64)
Memory used 437,699k (± 0.05%) 437,244k (± 0.07%) -454k (- 0.10%) 436,520k 437,571k
Parse Time 2.01s (± 0.47%) 2.03s (± 0.63%) +0.02s (+ 0.75%) 2.00s 2.05s
Bind Time 0.63s (± 1.18%) 0.63s (± 1.09%) -0.00s (- 0.63%) 0.61s 0.64s
Check Time 11.54s (± 0.86%) 11.63s (± 1.03%) +0.09s (+ 0.78%) 11.46s 11.89s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 14.18s (± 0.70%) 14.28s (± 0.85%) +0.10s (+ 0.71%) 14.08s 14.54s
Angular - node (v8.9.0, x64)
Memory used 340,422k (± 0.02%) 340,027k (± 0.01%) -394k (- 0.12%) 339,926k 340,092k
Parse Time 2.54s (± 0.44%) 2.52s (± 0.44%) -0.01s (- 0.47%) 2.50s 2.56s
Bind Time 0.85s (± 0.89%) 0.84s (± 0.81%) -0.01s (- 1.17%) 0.83s 0.86s
Check Time 5.33s (± 0.55%) 5.41s (± 0.79%) +0.08s (+ 1.44%) 5.30s 5.50s
Emit Time 5.98s (± 0.88%) 5.93s (± 0.84%) -0.05s (- 0.82%) 5.85s 6.07s
Total Time 14.70s (± 0.30%) 14.71s (± 0.52%) +0.01s (+ 0.05%) 14.56s 14.89s
Monaco - node (v8.9.0, x64)
Memory used 340,467k (± 0.01%) 340,455k (± 0.01%) -13k (- 0.00%) 340,382k 340,526k
Parse Time 1.87s (± 0.47%) 1.87s (± 0.56%) -0.00s (- 0.00%) 1.85s 1.90s
Bind Time 0.88s (± 0.45%) 0.88s (± 0.42%) -0.00s (- 0.34%) 0.87s 0.88s
Check Time 5.36s (± 0.58%) 5.42s (± 0.49%) +0.06s (+ 1.03%) 5.37s 5.48s
Emit Time 3.22s (± 0.41%) 3.22s (± 0.49%) +0.01s (+ 0.16%) 3.18s 3.26s
Total Time 11.33s (± 0.43%) 11.39s (± 0.30%) +0.06s (+ 0.51%) 11.33s 11.50s
TFS - node (v8.9.0, x64)
Memory used 303,763k (± 0.01%) 303,767k (± 0.02%) +3k (+ 0.00%) 303,646k 303,904k
Parse Time 1.55s (± 0.92%) 1.54s (± 0.31%) -0.00s (- 0.19%) 1.53s 1.55s
Bind Time 0.67s (± 0.67%) 0.67s (± 0.60%) +0.00s (+ 0.15%) 0.66s 0.68s
Check Time 4.99s (± 1.47%) 5.08s (± 1.51%) +0.09s (+ 1.89%) 4.93s 5.22s
Emit Time 3.04s (± 3.30%) 3.03s (± 2.90%) -0.01s (- 0.30%) 2.90s 3.22s
Total Time 10.24s (± 0.35%) 10.33s (± 0.44%) +0.08s (+ 0.82%) 10.26s 10.43s
material-ui - node (v8.9.0, x64)
Memory used 463,609k (± 0.01%) 463,364k (± 0.01%) -245k (- 0.05%) 463,261k 463,518k
Parse Time 2.39s (± 0.73%) 2.39s (± 0.66%) -0.00s (- 0.21%) 2.36s 2.44s
Bind Time 0.78s (± 0.98%) 0.77s (± 1.22%) -0.00s (- 0.39%) 0.75s 0.79s
Check Time 17.11s (± 1.10%) 17.12s (± 1.08%) +0.01s (+ 0.08%) 16.65s 17.42s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 20.28s (± 0.99%) 20.28s (± 0.90%) +0.01s (+ 0.03%) 19.80s 20.57s
Angular - node (v8.9.0, x86)
Memory used 195,298k (± 0.03%) 195,066k (± 0.01%) -233k (- 0.12%) 195,000k 195,132k
Parse Time 2.46s (± 0.51%) 2.46s (± 0.69%) +0.00s (+ 0.12%) 2.43s 2.50s
Bind Time 0.99s (± 0.75%) 0.98s (± 0.59%) -0.01s (- 0.71%) 0.97s 1.00s
Check Time 4.81s (± 0.44%) 4.87s (± 0.56%) +0.06s (+ 1.23%) 4.83s 4.96s
Emit Time 5.91s (± 1.20%) 5.91s (± 1.15%) +0.01s (+ 0.10%) 5.75s 6.04s
Total Time 14.17s (± 0.45%) 14.23s (± 0.63%) +0.06s (+ 0.44%) 14.02s 14.41s
Monaco - node (v8.9.0, x86)
Memory used 193,429k (± 0.02%) 193,485k (± 0.02%) +56k (+ 0.03%) 193,383k 193,610k
Parse Time 1.90s (± 0.69%) 1.91s (± 0.67%) +0.01s (+ 0.47%) 1.87s 1.93s
Bind Time 0.70s (± 0.96%) 0.70s (± 0.88%) +0.00s (+ 0.57%) 0.69s 0.72s
Check Time 5.48s (± 0.42%) 5.49s (± 1.14%) +0.01s (+ 0.26%) 5.28s 5.63s
Emit Time 2.67s (± 0.89%) 2.71s (± 3.18%) +0.04s (+ 1.46%) 2.64s 3.05s
Total Time 10.74s (± 0.30%) 10.81s (± 0.42%) +0.07s (+ 0.63%) 10.72s 10.94s
TFS - node (v8.9.0, x86)
Memory used 173,700k (± 0.02%) 173,714k (± 0.03%) +15k (+ 0.01%) 173,620k 173,824k
Parse Time 1.58s (± 0.87%) 1.60s (± 1.24%) +0.01s (+ 0.76%) 1.57s 1.65s
Bind Time 0.63s (± 0.94%) 0.64s (± 1.21%) +0.01s (+ 1.10%) 0.63s 0.66s
Check Time 4.60s (± 0.38%) 4.70s (± 0.54%) +0.10s (+ 2.09%) 4.67s 4.78s
Emit Time 2.79s (± 0.85%) 2.79s (± 1.20%) -0.00s (- 0.00%) 2.72s 2.86s
Total Time 9.61s (± 0.34%) 9.72s (± 0.55%) +0.11s (+ 1.17%) 9.63s 9.85s
material-ui - node (v8.9.0, x86)
Memory used 262,557k (± 0.02%) 262,366k (± 0.02%) -191k (- 0.07%) 262,298k 262,536k
Parse Time 2.44s (± 0.88%) 2.46s (± 0.69%) +0.02s (+ 0.90%) 2.44s 2.51s
Bind Time 0.67s (± 0.71%) 0.67s (± 1.09%) +0.00s (+ 0.15%) 0.65s 0.68s
Check Time 15.62s (± 0.76%) 15.65s (± 0.55%) +0.03s (+ 0.22%) 15.51s 15.85s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 18.72s (± 0.60%) 18.78s (± 0.47%) +0.06s (+ 0.30%) 18.64s 18.97s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-166-generic
Architecturex64
Available Memory16 GB
Available Memory1 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v8.9.0, x64)
  • node (v8.9.0, x86)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v8.9.0, x64)
  • Angular - node (v8.9.0, x86)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v8.9.0, x64)
  • Monaco - node (v8.9.0, x86)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v8.9.0, x64)
  • TFS - node (v8.9.0, x86)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v8.9.0, x64)
  • material-ui - node (v8.9.0, x86)
Benchmark Name Iterations
Current 39388 10
Baseline master 10

@sandersn sandersn mentioned this pull request Jul 2, 2020
Merged
@sandersn sandersn closed this Jul 2, 2020
@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 3, 2020

What's up

@sandersn
Copy link
Member

sandersn commented Jul 6, 2020

I'm not sure? Maybe because I mentioned it in #39323?

@sandersn
Copy link
Member

sandersn commented Jul 6, 2020

oh. nope. it's because it's based on the branch node-based-deprecated-checks. It needs to be rebased from master if that's possible or else cherry-picked over there.

@Kingwl
Copy link
Contributor Author

Kingwl commented Jul 7, 2020

Never mind. I have another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kingwl @typescript-bot @sandersn