Adapt to API break where resolve_literal takes an InputInfo arg. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upstream FxImporter, an `info` arg was added to resolve_literal. Adding it to the hooks here (without use) so that iree-turbine is forward/backward compatible with respect to this change. Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
ScottTodd
approved these changes
Sep 5, 2024
rsuderman
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upstream FxImporter, an
infoarg was added to resolve_literal. Adding it to the hooks here (without use) so that iree-turbine is forward/backward compatible with respect to this change.See llvm/torch-mlir#3688