[FxImporter] Add InputInfo to Resolve Literal Hook #3688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penguin-wwy
approved these changes
Sep 5, 2024
stellaraccident
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thanks. Since this will be an API break, we'll need to do an interlocked update of iree-turbine. I'll land I change there today which accepts this argument as optional so we have an easier compatibility window (so that the people who upgrade iree next aren't in a break the world situation).
stellaraccident
added a commit
to iree-org/iree-turbine
that referenced
this pull request
Sep 5, 2024
In the upstream FxImporter, an `info` arg was added to resolve_literal. Adding it to the hooks here (without use) so that iree-turbine is forward/backward compatible with respect to this change. See llvm/torch-mlir#3688 Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
stellaraccident
pushed a commit
to iree-org/iree-turbine
that referenced
this pull request
Sep 24, 2024
Fixes #85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <mcgirr@roofline.ai> Co-authored-by: Maximilian Bartel <bartel@roofline.ai>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <mcgirr@roofline.ai> Co-authored-by: Maximilian Bartel <bartel@roofline.ai>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <mcgirr@roofline.ai> Co-authored-by: Maximilian Bartel <bartel@roofline.ai> Signed-off-by: Ian <ian.nordeng@amd.com>
IanNod
pushed a commit
to IanNod/iree-turbine
that referenced
this pull request
Sep 30, 2024
Fixes iree-org#85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <mcgirr@roofline.ai> Co-authored-by: Maximilian Bartel <bartel@roofline.ai> Signed-off-by: Ian <ian.nordeng@amd.com>
stellaraccident
pushed a commit
to iree-org/iree-turbine
that referenced
this pull request
Oct 13, 2024
Fixes #85 PR based on the work of @maxbartel Requires changes in torch-mlir: [llvm/torch-mlir/#3688](llvm/torch-mlir#3688) Adds the mutable modifier to a global buffer and lifts said buffer to a global if there is a store-producer node associated with it. Signed-off-by: Christopher McGirr <mcgirr@roofline.ai> Co-authored-by: Maximilian Bartel <bartel@roofline.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes iree-org/iree-turbine#85
iree-turbine uses the FxImporter hooks to materialize buffers as global constants. In this particular use case we have a buffer that is modified which requires the mutable modifier.
However, this information is not available in the current API as the InputInfo structure is not passed to the literal resolution.
The following change passes the information to the literal API of the FxImporterHook.