Remove deprecated constraints and dynamic dim support with test fixes #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this, we can remove the torch restriction here: https://github.com/iree-org/iree-turbine/blob/main/pytorch-rocm-requirements.txt#L3 |
The backing APIs have been deprecated for a year and were removed from PyTorch 2.6 nightlies, causing import errors. torch.export and torch-mlir have long since provided a supported way for exporting dynamic dims. Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com> Signed-off-by: Ian <ian.nordeng@amd.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
Signed-off-by: Ian <ian.nordeng@amd.com>
IanNod
force-pushed
the
ian/pt_rm_constraints
branch
from
e6b6be8 to
5ee38d0
Compare
saienduri
approved these changes
Oct 18, 2024
ScottTodd
added a commit
to nod-ai/shark-ai
that referenced
this pull request
Oct 31, 2024
Progress on #294. Once this is merged the nightly package builds will start pushing `sharktank-{VERSION}-py3-none-any.whl` to https://github.com/nod-ai/SHARK-Platform/releases/tag/dev-wheels alongside the existing shortfin wheels. Tested at https://github.com/ScottTodd/SHARK-Platform/actions/runs/11621153296/job/32364368882 (ignore the push failure at the end, missing a token). --- Note that the 250KB Python wheel can be _installed_ standalone, but actually _using_ it will need version bumps across projects and more work. In particular, I hit 1. Using iree-turbine from pypi: ``` from sharktank import ops ... ImportError: cannot import name 'dynamic_dim' from 'torch.export' (/home/nod/dev/scratch/shark-platform/3.11.venv/lib/python3.11/site-packages/torch/export/__init__.py) ``` That may be fixed by iree-org/iree-turbine#233 2. After installing iree-turbine from source: ``` from sharktank import ops ... from gguf import GGUFReader, GGUFValueType ModuleNotFoundError: No module named 'gguf' ``` Full logs here: https://gist.github.com/ScottTodd/4cd0c343a92375e7fbdaaf37c38bfc06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backing APIs have been deprecated for a year and were removed from PyTorch 2.6 nightlies, causing import errors.
torch.export and torch-mlir have long since provided a supported way for exporting dynamic dims.