Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build sharktank packages nightly. #404

Merged
merged 6 commits into from
Oct 31, 2024

Conversation

ScottTodd
Copy link
Member

Progress on #294. Once this is merged the nightly package builds will start pushing sharktank-{VERSION}-py3-none-any.whl to https://github.com/nod-ai/SHARK-Platform/releases/tag/dev-wheels alongside the existing shortfin wheels.

Tested at https://github.com/ScottTodd/SHARK-Platform/actions/runs/11621153296/job/32364368882 (ignore the push failure at the end, missing a token).


Note that the 250KB Python wheel can be installed standalone, but actually using it will need version bumps across projects and more work. In particular, I hit

  1. Using iree-turbine from pypi:
    from sharktank import ops
    ...
    
    ImportError: cannot import name 'dynamic_dim' from 'torch.export' (/home/nod/dev/scratch/shark-platform/3.11.venv/lib/python3.11/site-packages/torch/export/__init__.py)
    
    That may be fixed by Remove deprecated constraints and dynamic dim support with test fixes iree-org/iree-turbine#233
  2. After installing iree-turbine from source:
    from sharktank import ops
    ...
    
        from gguf import GGUFReader, GGUFValueType
    ModuleNotFoundError: No module named 'gguf'
    

Full logs here: https://gist.github.com/ScottTodd/4cd0c343a92375e7fbdaaf37c38bfc06

@ScottTodd ScottTodd merged commit 362cfe1 into nod-ai:main Oct 31, 2024
10 of 11 checks passed
@ScottTodd ScottTodd deleted the sharktank-package-build branch October 31, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants