Add strip assertions flag #19014
Merged
Add strip assertions flag #19014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanWood1
force-pushed
the
strip_assertions
branch
from
da92beb to
aa1a755
Compare
IanWood1
force-pushed
the
strip_assertions
branch
2 times, most recently
from
dfe6e48 to
5da931f
Compare
IanWood1
requested review from
hanhanW,
ScottTodd,
benvanik and
stellaraccident
as code owners
Part 1 (this pr): add `iree-opt-strip-assertions` to CI. Part 2: remove flag usage and make this default. Issue: iree-org#1900 Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
|
Could I get a review on this? This might also be affecting Llama performance, there were ~100 dispatches that could be CSEed if the asserts were removed. |
benvanik
approved these changes
Nov 13, 2024
|
The idea was to to fix sdxl regressions first by just using the flag, then make it default after because there may be some side effects of stripping all assertions like this by default. But I can change this to be default if that seems better |
Makes sense. Lets keep to the original plan. |
MaheshRavishankar
approved these changes
Nov 14, 2024
Groverkss
pushed a commit
to Groverkss/iree
that referenced
this pull request
Dec 1, 2024
This change _temporarily_ adds `iree-opt-strip-assertions` to SDXL CI which should fix the regression discussed in iree-org#19002. Assertions within `linalg.generic` ops can mess with dispatch creation and lead to poorly performing dispatches, despite the fact that they get stripped in later pipelines. --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu>
giacs-epic
pushed a commit
to giacs-epic/iree
that referenced
this pull request
Dec 4, 2024
This change _temporarily_ adds `iree-opt-strip-assertions` to SDXL CI which should fix the regression discussed in iree-org#19002. Assertions within `linalg.generic` ops can mess with dispatch creation and lead to poorly performing dispatches, despite the fact that they get stripped in later pipelines. --------- Signed-off-by: Ian Wood <ianwood2024@u.northwestern.edu> Signed-off-by: Giacomo Serafini <179146510+giacs-epic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change temporarily adds
iree-opt-strip-assertionsto SDXL CI which should fix the regression discussed in #19002. Assertions withinlinalg.genericops can mess with dispatch creation and lead to poorly performing dispatches, despite the fact that they get stripped in later pipelines.Part 2 (future PR or maybe this one): remove flag usage and make this default.