[DT] Switch MaterializeEncodingIntoNop to use EncodingLayoutAttr. #19294
+195
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanhanW
force-pushed
the
iree-codegen-interface
branch
3 times, most recently
from
da0bd66
to
ed7f415
Compare
hanhanW
requested review from
antiagainst,
qedawkins and
MaheshRavishankar
as code owners
|
It depends on #19292, please take a look at the last commit. Technically, it is NFC because it only shuffle the codes and make few changes. So there are no new tests. However, I do update logics for some passes and methods and introduce new things, so I do not mark it NFC in PR title. |
The revision introduces LayoutAttrInterface attribute interface and implements the codegen attribute that discards the encodings for lowering. It is used in the MaterializeEncodingIntoNop pass that turns encodings into nop. The layout attributes for other backends are not implemented, so the GPU/CPU materialization pass does not take it into account. The revision also implements a isIdentityLayout method for the MaterializeEncodingInfo struct and adds an unit test for it. Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
iree-codegen-interface
branch
from
ed7f415
to
dfaa723
Compare
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
commented
Nov 26, 2024
compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenInterfaces.td
Outdated
Show resolved
Hide resolved
hanhanW
commented
Nov 26, 2024
| // iree_codegen.encoding_layout | ||
| //===---------------------------------------------------------------------===// | ||
|
|
||
| def IREECodegen_EncodingLayoutAttr : |
There was a problem hiding this comment.
I should probably rename it to EncodingNopLayoutAttr, which is clearer.
Signed-off-by: hanhanW <hanhan0912@gmail.com>
|
This POC shows that we're able to implement the attribute for VMVX backend. There are some dup code in the POC though. I think my next step is moving most of methods from |
bjacob
reviewed
Nov 27, 2024
compiler/src/iree/compiler/Codegen/Dialect/Codegen/IR/IREECodegenAttrs.cpp
Outdated
Show resolved
Hide resolved
compiler/src/iree/compiler/Codegen/Common/MaterializeEncodingIntoPackUnPack.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
iree-codegen-interface
branch
from
2eca2f9
to
af409d0
Compare
bjacob
approved these changes
Nov 28, 2024
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The revision introduces LayoutAttrInterface attribute interface and
implements the codegen attribute that discards the encodings for
lowering. It is used in the MaterializeEncodingIntoNop pass that turns
encodings into nop.
The new interface has two methods in the patch:
getEncodingInfo: It takes a ranked tensor type and returns the layout.lowerOp: It takes the operation, converted operands and result types to lower the op.The layout attributes for other backends are not implemented, so the
GPU/CPU materialization pass does not take it into account.
The revision also implements a isIdentityLayout method for the
MaterializeEncodingInfo struct and adds an unit test for it.
To support identity layout materialization, it adds a shortcut for lowering set/unset encodings ops to packing ops. If the relayout is not needed, the original source tensor value is returned. It is possible to add a folder for pack ops, but it is hard for unpack ops. Because the unpack ops have slicing semantics and it is not easy to identify it. Also, creating an operation is not cheap, so we have the shortcut in the two methods.
There are no new lit tests because the tests are covered by materialize_encoding_into_nop.mlir