Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DT] Switch MaterializeEncodingIntoNop to use EncodingNopLayoutAttr. #19294

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[DT] Switch MaterializeEncodingIntoNop to use EncodingNopLayoutAttr. #19294

wants to merge 7 commits into from

Commits on Nov 26, 2024

  1. [DT] Switch MaterializeEncodingIntoNop to use EncodingLayoutAttr. 

    The revision introduces LayoutAttrInterface attribute interface and
implements the codegen attribute that discards the encodings for
lowering. It is used in the MaterializeEncodingIntoNop pass that turns
encodings into nop.

The layout attributes for other backends are not implemented, so the
GPU/CPU materialization pass does not take it into account.

The revision also implements a isIdentityLayout method for the
MaterializeEncodingInfo struct and adds an unit test for it.

Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    dfaa723 View commit details
    Browse the repository at this point in the history

  2. Register Codegen dialect for dynamic pipeline. 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    775e886 View commit details
    Browse the repository at this point in the history

  3. Refine interface method and rename attribute to EncodingNopLayoutAttr 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    8052d3f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. address review comments 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    af409d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2024

  1. fix grammar error 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    791eb96 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into iree-codegen-interface 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    8fbf9e8 View commit details
    Browse the repository at this point in the history

  3. IWYU 

    Signed-off-by: hanhanW <hanhan0912@gmail.com>
    @hanhanW
    hanhanW committed Nov 28, 2024
    Configuration menu
    Copy the full SHA
    2a66111 View commit details
    Browse the repository at this point in the history