feat(vaccination report): Apps connected to EPS can submit a vaccinatio… #651

jekutzsche · 2022-03-02T19:56:01Z

…n report via the JSON-RPC method submitVaccinationInfoList. The information is saved and made available to health department staff via the front end.

Refs iris-connect/iris-backlog#274

lucky-lusa · 2022-03-03T16:15:37Z

iris-client-bff/src/main/java/iris/client_bff/core/validation/PhoneNumber.java

+
+			try {
+
+				var number = util.parse(text, "DE");


So we are only checking for DE numbers. We should enforce the country code by regex and validate against the correct country. There will be employees with foreign country phone numbers.

No, we do not check only for DE. This "DE" parameter is the default Region and is used if the number without country code.

From JavaDoc of the parse method:

defaultRegion: region that we are expecting the number to be from. This is only used if the number being parsed is not written in international format. The country_code for the number in this case would be stored as that of the default region supplied. If the number is guaranteed to start with a '+' followed by the country calling code, then RegionCode.ZZ or null can be supplied.

I have added valid non-German phone numbers with country code in the test.

Thank you. Nevertheless we should enforce the country code by regex I think.

If we allow numbers without country code they will be used as "DE". This will lead to inaccuracies if numbers from other countries are entered without country code.

Regex? Oh my God, no way! I prefer to do it differently. ;)

…n information lists via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. Refs iris-connect/iris-backlog#274

github-actions · 2022-03-07T08:43:50Z

Unit Test Results

  40 files +  2   40 suites +2 3m 3s ⏱️ -40s
228 tests +30 228 ✔️ +30 0 💤 ±0 0 ❌ ±0

Results for commit 5bc53f7. ± Comparison against base commit c38078a.

This pull request removes 6 and adds 36 tests. Note that renamed tests count towards both.

iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_InvalidBase64PublicKey_ReturnsValidationErrors
iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_InvalidJson_ReturnsValidationErrors{String, String, String}[1]
iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_InvalidJson_ReturnsValidationErrors{String, String, String}[2]
iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_InvalidJson_ReturnsValidationErrors{String, String, String}[3]
iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_InvalidPublicKey_Returns500
iris.client_bff.vaccination_info.eps.VaccinationInfoControllerIntegrationTest ‑ announceVaccinationInfoList_ValidJson_ReturnsEncryptedTokens

iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[10]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[11]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[12]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[13]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[14]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[1]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[2]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[3]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[4]
iris.client_bff.core.validation.PhoneNumberTests ‑ validate_withInvalidValue_getViolations{String}[5]
…

# [1.5.0-rc.1](v1.4.1...v1.5.0-rc.1) (2022-03-09) ### Bug Fixes * Adds grpc server to client EPS. Still not reachable from outside, but necessary for communication between health departments. ([679c08e](679c08e)), closes [#637](#637) * Fixes an error when changing user data (IllegalStateException: Cannot convert value of type 'java.lang.String' […] no matching editors or conversion strategy found). ([58b3d42](58b3d42)) ### Features * Adds a hint to search for hd-contacts by postal code or city into the message input frontend. ([032a648](032a648)), closes [#632](#632) [#636](#636) * Displays meta-data (who and when created/last modified an entity) on event-tracking, index-tracking and user detail pages. ([da1b7a6](da1b7a6)), closes [iris-connect/iris-backlog#234](https://github.com/iris-connect/iris-backlog/issues/234) [#638](#638) * **vaccination report:** Apps connected to EPS can announce the submission of a vaccination report via the JSON-RPC method `announceVaccinationInfoList`. A transmission channel is then opened briefly for the respective user of the app. ([c38078a](c38078a)), closes [iris-connect/iris-backlog#273](https://github.com/iris-connect/iris-backlog/issues/273) [#635](#635) * **vaccination report:** Apps connected to EPS can submit a vaccination report via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. ([72b1f74](72b1f74)), closes [iris-connect/iris-backlog#274](https://github.com/iris-connect/iris-backlog/issues/274) [#651](#651) * **vaccination report:** There is a new view in the front end with an overview of submitted vaccination reports. In the details view of a vaccination report, the submitted persons are displayed with their vaccination status. ([00e93e8](00e93e8)), closes [iris-connect/iris-backlog#275](https://github.com/iris-connect/iris-backlog/issues/275) [#629](#629)

jekutzsche · 2022-03-09T10:24:56Z

🎉 This PR is included in version 1.5.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.5.0](v1.4.1...v1.5.0) (2022-03-16) ### Bug Fixes * Adds grpc server to client EPS. Still not reachable from outside, but necessary for communication between health departments. ([679c08e](679c08e)), closes [#637](#637) * Fixes an error when changing user data (IllegalStateException: Cannot convert value of type 'java.lang.String' […] no matching editors or conversion strategy found). ([58b3d42](58b3d42)) ### Features * Adds a hint to search for hd-contacts by postal code or city into the message input frontend. ([032a648](032a648)), closes [#632](#632) [#636](#636) * Displays meta-data (who and when created/last modified an entity) on event-tracking, index-tracking and user detail pages. ([da1b7a6](da1b7a6)), closes [iris-connect/iris-backlog#234](https://github.com/iris-connect/iris-backlog/issues/234) [#638](#638) * **Docker Compose:** Adds scope labels to the services in the Docker Compose file to avoid conflicts with possibly existing other instances of Watchtower on the same Docker host. ([499267f](499267f)), closes [#666](#666) * **Messages:** Uses `_ping` and the EPS version check when building the recipient list to determine if a health department is able to receive messages. This avoids additional configuration and enables faster propagation of the feature. ([446da17](446da17)), closes [#668](#668) * **vaccination report:** Apps connected to EPS can announce the submission of a vaccination report via the JSON-RPC method `announceVaccinationInfoList`. A transmission channel is then opened briefly for the respective user of the app. ([c38078a](c38078a)), closes [iris-connect/iris-backlog#273](https://github.com/iris-connect/iris-backlog/issues/273) [#635](#635) * **vaccination report:** Apps connected to EPS can submit a vaccination report via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. ([72b1f74](72b1f74)), closes [iris-connect/iris-backlog#274](https://github.com/iris-connect/iris-backlog/issues/274) [#651](#651) * **vaccination report:** There is a new view in the front end with an overview of submitted vaccination reports. In the details view of a vaccination report, the submitted persons are displayed with their vaccination status. ([00e93e8](00e93e8)), closes [iris-connect/iris-backlog#275](https://github.com/iris-connect/iris-backlog/issues/275) [#629](#629)

jekutzsche · 2022-03-16T09:35:30Z

🎉 This PR is included in version 1.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jekutzsche requested a review from lucky-lusa March 2, 2022 19:56

jekutzsche force-pushed the feature/BL274-Submit_Vaccination_Info_List branch from 6fa4277 to a53289a Compare March 3, 2022 13:16

jekutzsche marked this pull request as ready for review March 3, 2022 13:17

lucky-lusa reviewed Mar 3, 2022

View reviewed changes

jekutzsche requested a review from lucky-lusa March 3, 2022 19:12

jekutzsche changed the title ~~feat(vaccination info): Apps connected to EPS can submit a vaccinatio…~~ feat(vaccination report): Apps connected to EPS can submit a vaccinatio… Mar 3, 2022

lucky-lusa previously approved these changes Mar 7, 2022

View reviewed changes

Base automatically changed from feature/BL273-Announce_Vaccination_Info_List to develop March 7, 2022 07:51

jekutzsche added 3 commits March 7, 2022 09:09

feat(vaccination info): Apps connected to EPS can submit a vaccinatio…

8ec2166

…n information lists via the JSON-RPC method `submitVaccinationInfoList`. The information is saved and made available to health department staff via the front end. Refs iris-connect/iris-backlog#274

chore: adds tests for non German phone numbers

2c85074

chore: makes country code mandatory

a732cd7

jekutzsche dismissed lucky-lusa’s stale review via a732cd7 March 7, 2022 08:21

jekutzsche force-pushed the feature/BL274-Submit_Vaccination_Info_List branch from 8a9d5e8 to a732cd7 Compare March 7, 2022 08:21

jekutzsche requested a review from lucky-lusa March 7, 2022 08:21

chore: fixes outdated SQL scripts

5bc53f7

lucky-lusa approved these changes Mar 7, 2022

View reviewed changes

jekutzsche merged commit 72b1f74 into develop Mar 7, 2022

jekutzsche deleted the feature/BL274-Submit_Vaccination_Info_List branch March 7, 2022 08:46

jekutzsche added the released on @release label Mar 9, 2022

jekutzsche added the released label Mar 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vaccination report): Apps connected to EPS can submit a vaccinatio… #651

feat(vaccination report): Apps connected to EPS can submit a vaccinatio… #651

jekutzsche commented Mar 2, 2022 •

edited

Loading

lucky-lusa Mar 3, 2022

jekutzsche Mar 3, 2022

jekutzsche Mar 3, 2022

lucky-lusa Mar 4, 2022

lucky-lusa Mar 4, 2022

jekutzsche Mar 4, 2022

github-actions bot commented Mar 7, 2022

jekutzsche commented Mar 9, 2022

jekutzsche commented Mar 16, 2022

feat(vaccination report): Apps connected to EPS can submit a vaccinatio… #651

feat(vaccination report): Apps connected to EPS can submit a vaccinatio… #651

Conversation

jekutzsche commented Mar 2, 2022 • edited Loading

lucky-lusa Mar 3, 2022

Choose a reason for hiding this comment

jekutzsche Mar 3, 2022

Choose a reason for hiding this comment

jekutzsche Mar 3, 2022

Choose a reason for hiding this comment

lucky-lusa Mar 4, 2022

Choose a reason for hiding this comment

lucky-lusa Mar 4, 2022

Choose a reason for hiding this comment

jekutzsche Mar 4, 2022

Choose a reason for hiding this comment

github-actions bot commented Mar 7, 2022

Unit Test Results

jekutzsche commented Mar 9, 2022

jekutzsche commented Mar 16, 2022

jekutzsche commented Mar 2, 2022 •

edited

Loading