add idle_timeout to fn tool

[c0ze]

It seems fn tool doesn't support setting idle_timeout param for hot function routes.

https://github.com/iron-io/functions/blob/master/docs/function-timeouts.md
https://github.com/iron-io/functions/blob/master/docs/hot-functions.md

To test, create an app, and a route with :

go run fn/main.go routes c --format=http --memory=2048 --timeout=60s --idle_timeout=60s hot-func /hot

modify hot-functions func.go to look something like :

func main() {
	var pre []byte

	for {
		res := http.Response{
			Proto:      "HTTP/1.1",
			ProtoMajor: 1,
			ProtoMinor: 1,
			StatusCode: 200,
			Status:     "OK",
		}

		r := bufio.NewReader(os.Stdin)
		req, err := http.ReadRequest(r)

		var buf bytes.Buffer
		if err != nil {
			res.StatusCode = 500
			res.Status = http.StatusText(res.StatusCode)
			fmt.Fprintln(&buf, err)
		} else {
			l, _ := strconv.Atoi(req.Header.Get("Content-Length"))
			p := make([]byte, l)
			r.Read(p)
			fmt.Fprintf(&buf, "Previous call was %s\n", pre)
			fmt.Fprintf(&buf, "Hello %s\n", p)
			for k, vs := range req.Header {
				fmt.Fprintf(&buf, "ENV: %s %#v\n", k, vs)
			}
			pre = p
		}

		res.Body = ioutil.NopCloser(&buf)
		res.ContentLength = int64(buf.Len())
		res.Write(os.Stdout)
	}
}

to keep a passed value, and print both when there is a request. Then you can call the function with :

curl -X POST localhost:8080/r/hot-func/hot -d 'Test'
curl -X POST localhost:8080/r/hot-func/hot -d 'Test 2'

You should see previous call in the second call output.

after a while, you should see the hot func spin down in the service logs

INFO[0142] Canceling inactive hot function               app=hot-func format=http idle_timeout=1m0s image="coze/hot:0.0.1" max_concurrency=1 memory=2048 route="/hot"
INFO[0142] container status                              container_error= container_finished=0001-01-01 00:00:00 +0000 UTC container_running=true container_status=running exit_code=0
INFO[0142]                                               name=run.hot-func.error type=count value=1
INFO[0142]                                               name=run.hot-func.time type=time value=1m3.2915359s
INFO[0142]                                               name="run.exec_time" type=time value=1m3.2915359s
INFO[0143] hot function terminated                       result=

without this patch (and setting idle_timeout) the function spins down immediately after serving the response.

[kunihiko-t]

LGTM 👍
I tested it with your command and func.yaml way and both of them succeeded.

[vasilev]

Looks good to me too.
Any chance to cover this with an autotest ?

[c0ze]

@kunihiko-t @vasilev

Thanks ! Yes I am looking at providing some test coverage. Might take a while !

[c0ze]

@kunihiko-t @vasilev

I added tests for setting idle_timeout (and every other param) from fn tool ! I would appreciate if you could take a look !

Regarding the test I posted go code above, it actually tests hot functions spin down behaviour, which is beyond the scope of this PR. This PR only deals with setting idle_timeout from fn tool.

[vasilev]

Looks good to me.
Thanks for tests!

[kunihiko-t]

Thank you! LGTM 👍

[kunihiko-t]

nits: I think IdleTimeout is better than IDLETimeout.

[c0ze]

Yes but unfortunately it is defined as IDLETimeout in functions_go (which is auto generated). I am not sure why it capitalizes.

[kunihiko-t]

Oh, so it's no problem.
Thanks 👍

[sss0350]

I'm checking your hotfunction example and trying to make it running on my environment.
(https://github.com/iron-io/functions/tree/master/examples/hotfunctions/http)
But it seems the idle_timeout is not possible setting from fn cmd.
I set it in func.yaml ( ex: idle_timeout:30 ) , and inpect it using fn routes inspect. But it always get 0.

And find this post , it seems you guys are working on it . Let me know when there's a patch of fn cmd.
And will be really nice if user can set on function-ui.

Just let you guys know my result. Thanks again.

[c0ze]

@sss0350 Thanks for the response !

Yes, this is actually ready to go, so setting idle_timeout from fn will be available in a few moments. (it will be version 0.2.72, so dont forget to update !)

Regarding UI, we already added it but it is not released yet. We will combine a couple of feature requests for UI and release a new version soon (hopefully in a couple of weeks) !

[sss0350]

I just get it a quick try this afternoon at my office, I can set idle_timeout from cmd.

1. fn routes update xxx xxx --idle_timeout=30s
2. fn routes inspect xxx xxx (can see idle_timeout set to 30s)

And trigger your hot function examples ( https://github.com/iron-io/functions/tree/master/examples/hotfunctions/http ), but find the containers still not keep alive within 30s.
After trigger function , and I check this hot function container thru docker ps | grep myfnname ,
it seems this container still be killed immediately after trigger. It should be alive within 30s , right?
Did I misunderstand anything here? Or any other steps should be done to make a hotfunction?

[c0ze]

Yes, it should be alive for the duration of idle timeout. You can see if it's being killed in the server logs. Can you see anything there?