Modify volumebroker to filter volumes before aggregation
#1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
balpert89
approved these changes
Nov 12, 2025
Rohit-0505
approved these changes
Nov 12, 2025
opensovereigncloud-user
force-pushed
the
osc/enh/update-volume-filtering
branch
from
f8dbd4e to
dff98fb
Compare
lukasfrank
requested changes
Nov 26, 2025
Member
lukasfrank
left a comment
lukasfrank
left a comment
There was a problem hiding this comment.
Does the proposed change work for existing Volumes . It looks like we recreate a Volume if the label is not present
| } | ||
|
|
||
| func (r *VolumeReconciler) deleteGone(ctx context.Context, log logr.Logger, volumeKey client.ObjectKey) (ctrl.Result, error) { | ||
| func (r *VolumeReconciler) deleteGone(ctx context.Context, log logr.Logger, volume *storagev1alpha1.Volume) (ctrl.Result, error) { |
Member
There was a problem hiding this comment.
Isn't the volume uninitialized if we get here an error?
volume := &storagev1alpha1.Volume{}
if err := r.Get(ctx, req.NamespacedName, volume); err != nil {
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
volumebrokerto filter volumes before aggregation and to addvolumepoollet.ironcore.dev/volume-uidlabel with parent volume uid as value inCreateVolumefunctionvolumepoolletto list and delete volumes usingvolumepoollet.ironcore.dev/volume-uidlabelFixes #1405