Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resubscribe to command topics when MQTT server restarts while service is active #99

Closed
karl500 opened this issue Apr 30, 2023 · 2 comments
Closed

Resubscribe to command topics when MQTT server restarts while service is active #99

karl500 opened this issue Apr 30, 2023 · 2 comments
Assignees
@ironsheep
Labels
bug Something isn't working

Comments

@karl500
Copy link

karl500 commented Apr 30, 2023

Checklist:

  • [ yes] I updated to the latest version available
  • [ yes] I checked that my MQTT broker is otherwise working

Release with the issue:
1.8.4

Last working release (if known):

Hardware, Operating System, Python version:
Rpi 3b r1.2, buster 5.4.51-v7+, python 3.7.3

Description of problem:
When MQTT server restarts while the service is active. MQTT is reconnected but command topics are not subscribed to again.
Subscribing to topics probably should be moved to the callback on_connect.

As this is a bug in code don't realy see the need for other info.

Run our report script 'genBugInfo' on your failing device and include the output here:

Python errors shown in the logs (if applicable):

Additional information:
@karl500 karl500 added the bug Something isn't working label Apr 30, 2023
@ironsheep ironsheep self-assigned this Apr 30, 2023
@ironsheep
Copy link
Owner

@karl500 thank you for reporting this. I'm working on the fix now...

ironsheep added a commit that referenced this issue May 1, 2023
@ironsheep
clean up docs and repair subscription to commands
45a20f9 
- Handle re-subscription if MQTT broker restarts (#99)
- Simplify installation / setup documentation (#97)
- Repair bug in running shell to execute commands
@ironsheep
Copy link
Owner

Changes committed and will appear in v1.8.5 and later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ironsheep ironsheep

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ironsheep @karl500