Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mntner with legacy auth can't be deleted #909

Closed
rubenskuhl opened this issue Feb 21, 2024 · 2 comments · Fixed by #912
Closed

mntner with legacy auth can't be deleted #909

rubenskuhl opened this issue Feb 21, 2024 · 2 comments · Fixed by #912

Comments

@rubenskuhl
Copy link

Describe the bug
A mntner with a method supported only for legacy authentication (like CRYPT-PW) can't be removed

To Reproduce
Have a previous object with CRYPT-PW, try deleting it.
ERROR: Invalid auth attribute: CRYPT-PW DummyValue: supported options are MD5-PW, BCRYPT-PW, PGPKEY-xxxxxxxx and IRRD-INTERNAL-AUTH for migrated objects

Expected behaviour
Deleting should care only about primary keys. The object should be removed.

IRRd version you are running
4.4.3

Additional context
This was probably introduced either by the code that enables legacy authentication in 4.4 mainline or the fix in 4.4.3

@mxsasha
Copy link
Collaborator

mxsasha commented Feb 21, 2024

I agree this should work. This is a more specific duplicate of #647

@rubenskuhl
Copy link
Author

rubenskuhl commented Feb 22, 2024

I agree this should work. This is a more specific duplicate of #647

I think solving #647 would solve this one, but they are different since this was introduced alongside the concept of phasing out legacy authentication methods. So I don't know which way you prefer handling it.

Also different is that auth is a required field in mntner objects... so the workaround is different from the other fields from #647. For those, omitting the field works better; for auth, it needs to be replaced with a currently valid for new passwords auth scheme.

mxsasha added a commit that referenced this issue Feb 23, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
@mxsasha mxsasha linked a pull request Feb 23, 2024 that will close this issue
mxsasha added a commit that referenced this issue Feb 26, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
mergify bot pushed a commit that referenced this issue Feb 26, 2024
When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

(cherry picked from commit 3239354)

# Conflicts:
#	irrd/updates/parser.py
mxsasha pushed a commit that referenced this issue Feb 26, 2024
…ackport #912) (#913)

When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

(cherry picked from commit 3239354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants