Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #647, fix #909 - Always parse delete object non-strict #912

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

mxsasha
Copy link
Collaborator

@mxsasha mxsasha commented Feb 23, 2024

When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909
@mxsasha mxsasha self-assigned this Feb 26, 2024
@mxsasha mxsasha merged commit 7a046b2 into main Feb 26, 2024
7 checks passed
@mxsasha mxsasha deleted the delnonstrict branch February 26, 2024 15:02
mxsasha pushed a commit that referenced this pull request Feb 26, 2024
…ackport #912) (#913)

When an object is deleted, the submitted object's values are
ignored except for the primary key. Therefore, there's no
need to validate them in strict mode.
This also disables the rules validator for deletion objects, re #909

(cherry picked from commit 3239354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mntner with legacy auth can't be deleted delete doing strict checking when not required
1 participant