-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds event term to randomize gains of explicit actuators #1005
Adds event term to randomize gains of explicit actuators #1005
Conversation
Can I have some guidance on how the test should be completed |
in articulation.py we could set the default_joint_stiffness and default_joint_damping properly , instead of settings all zeros for explicit actuators. this would simplify this PR. ...
set defaults from the sim first
...
for actuator_name, actuator_cfg in self.cfg.actuators.items():
if isinstance(actuator, ImplicitActuator):
self.write_joint_xxx
...
else:
self.write_joint_xxx
...
# over write the defaults we got from the sim with our local data
self._data.default_joint_stiffness[slice(None), actuator.joint_indices] = (
actuator._parse_joint_parameter(actuator.cfg.stiffness, actuator.stiffness)
)
self._data.default_joint_damping[slice(None), actuator.joint_indices] = (
actuator._parse_joint_parameter(actuator.cfg.damping, actuator.damping)
) |
85bd8ae
to
1f1a943
Compare
Added my proposed changes to articulations.py to this PR. |
ce45788
to
8e09244
Compare
source/extensions/omni.isaac.lab/omni/isaac/lab/actuators/actuator_base.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/events.py
Outdated
Show resolved
Hide resolved
This is great stuff, thanks @MoreTore! |
@Dhoeller19 Thanks for the review! I have a newer version that I have been using. I will incorporate the suggestions you noted. |
e1a6d9c
to
e470449
Compare
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/events.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/events.py
Outdated
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/mdp/events.py
Outdated
Show resolved
Hide resolved
@MoreTore sorry that it took so long. We can merge as soon as you check the last conversation and formatting is run with |
Yea the issue now will be making sure the merge doesn't break the other changes I made :p |
…ator models. isaac-sim#1000 Set default stiffness, damping for explicit actuators isaac-sim#1006 fixes randomize_joint_parameters shape mismatch isaac-sim#1011
2d56c27
to
a355128
Compare
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
…acLab into explicit-gain-randomization
…acLab into explicit-gain-randomization
) # Description resolves: isaac-sim#1000 resolves: isaac-sim#1011 depends: isaac-sim#1006 ## Type of change - New feature (non-breaking change which adds functionality) - This change may require a documentation update ## Checklist - [x] have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] My changes generate no new warnings - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there - [x] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Description
resolves: #1000
resolves: #1011
depends: #1006
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
CONTRIBUTORS.md
or my name already exists thereconfig/extension.toml
file