Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds event term to randomize gains of explicit actuators #1005

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

MoreTore
Copy link
Contributor

@MoreTore MoreTore commented Sep 20, 2024

Description

resolves: #1000
resolves: #1011
depends: #1006

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change may require a documentation update

Checklist

  • have run the pre-commit checks with ./isaaclab.sh --format
  • My changes generate no new warnings
  • I have added my name to the CONTRIBUTORS.md or my name already exists there
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file

@MoreTore
Copy link
Contributor Author

Can I have some guidance on how the test should be completed

@MoreTore
Copy link
Contributor Author

MoreTore commented Sep 20, 2024

in articulation.py we could set the default_joint_stiffness and default_joint_damping properly , instead of settings all zeros for explicit actuators. this would simplify this PR.
but for example in source/extensions/omni.isaac.lab/omni/isaac/lab/assets/articulation/articulation.py:

...
set defaults from the sim first
...


for actuator_name, actuator_cfg in self.cfg.actuators.items():
  if isinstance(actuator, ImplicitActuator):
     self.write_joint_xxx
     ...
  else:
     self.write_joint_xxx
     ...
     # over write the defaults we got from the sim with our local data
     self._data.default_joint_stiffness[slice(None), actuator.joint_indices] = (
        actuator._parse_joint_parameter(actuator.cfg.stiffness, actuator.stiffness)
     )
     self._data.default_joint_damping[slice(None), actuator.joint_indices] = (
        actuator._parse_joint_parameter(actuator.cfg.damping, actuator.damping)
     )

@MoreTore
Copy link
Contributor Author

Added my proposed changes to articulations.py to this PR.

@Dhoeller19
Copy link
Collaborator

This is great stuff, thanks @MoreTore!

@MoreTore
Copy link
Contributor Author

@Dhoeller19 Thanks for the review! I have a newer version that I have been using. I will incorporate the suggestions you noted.

@Dhoeller19
Copy link
Collaborator

Dhoeller19 commented Oct 28, 2024

@MoreTore sorry that it took so long. We can merge as soon as you check the last conversation and formatting is run with ./isaaclab.sh -f

@MoreTore
Copy link
Contributor Author

@MoreTore sorry that it took so long. We can merge as soon as you check the last conversation and formatting is run with ./isaaclab.sh -f

Yea the issue now will be making sure the merge doesn't break the other changes I made :p

…ator models. isaac-sim#1000

Set default stiffness, damping for explicit actuators isaac-sim#1006

fixes randomize_joint_parameters shape mismatch isaac-sim#1011
@Mayankm96 Mayankm96 changed the title Explicit actuator gain randomization Adds event term to randomize gains of explicit actuators Oct 31, 2024
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
@Dhoeller19 Dhoeller19 merged commit 281f9b0 into isaac-sim:main Nov 1, 2024
5 checks passed
iamdrfly pushed a commit to iamdrfly/IsaacLab that referenced this pull request Nov 21, 2024
)

# Description
resolves: isaac-sim#1000
resolves: isaac-sim#1011
depends: isaac-sim#1006

## Type of change
- New feature (non-breaking change which adds functionality)
- This change may require a documentation update

## Checklist

- [x] have run the [`pre-commit` checks](https://pre-commit.com/) with
`./isaaclab.sh --format`
- [x] My changes generate no new warnings
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
- [x] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants