Fixes setting the seed from CLI for RSL-RL #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaixi287
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11 and
Mayankm96
as code owners
Mayankm96
approved these changes
Oct 1, 2024
Mayankm96
changed the title
|
Thank you for the fix! |
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
# Description This pull request fixes a bug that prevented setting the seed from CLI arguments. The issue was caused by an extra pair of quotation marks in the `hasattr` check for `args_cli`. Removing these allows the seed to be correctly set via CLI. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes a bug that prevented setting the seed from CLI arguments. The issue was caused by an extra pair of quotation marks in the
hasattrcheck forargs_cli. Removing these allows the seed to be correctly set via CLI.Type of change
Screenshots
Before: The seed could not be set via CLI due to an extra pair of quotation marks around
args_cliin thehasattrcheck.After: The seed can now be correctly set from CLI.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there