Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Isaac Sim executable on pip installation #1172

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Fixes Isaac Sim executable on pip installation #1172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0f25ea
Check for installation using Isaac Sim pip and get the Python entry p…
Toni-SM Oct 7, 2024
c92c89a
Merge branch 'main' into fix/isaacsim_executable_pip
Toni-SM Oct 7, 2024
9864a9a
Add omni.isaac.sim as default experience file for Isaac Sim PIP execu…
Toni-SM Oct 7, 2024
4b43618
Merge branch 'main' into fix/isaacsim_executable_pip
Dhoeller19 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion isaaclab.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ if errorlevel 1 (
set isaacsim_exe=!isaac_path!\isaac-sim.bat
) else (
rem if isaac sim installed from pip
set isaacsim_exe=isaacsim
set isaacsim_exe=isaacsim omni.isaac.sim
Toni-SM marked this conversation as resolved.
Show resolved Hide resolved
)
rem check if there is a python path available
if not exist "%isaacsim_exe%" (
Expand Down
10 changes: 8 additions & 2 deletions isaaclab.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,14 @@ extract_isaacsim_exe() {
local isaacsim_exe=${isaac_path}/isaac-sim.sh
# check if there is a python path available
if [ ! -f "${isaacsim_exe}" ]; then
echo "[ERROR] No Isaac Sim executable found at path: ${isaacsim_exe}" >&2
exit 1
# check for installation using Isaac Sim pip
if [ $(python -m pip list | grep -c 'isaacsim-rl') -gt 0 ]; then
# Isaac Sim - Python packages entry point
local isaacsim_exe="isaacsim omni.isaac.sim"
Toni-SM marked this conversation as resolved.
Show resolved Hide resolved
else
echo "[ERROR] No Isaac Sim executable found at path: ${isaac_path}" >&2
exit 1
fi
fi
# return the result
echo ${isaacsim_exe}
Expand Down
Loading