Allows configclass to_dict operation to handle a list of configclasses
#1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhoeller19
reviewed
Oct 14, 2024
Dhoeller19
requested review from
Mayankm96,
jsmith-bdai and
kellyguo11
as code owners
Co-authored-by: David Hoeller <dhoeller@nvidia.com> Signed-off-by: jtigue-bdai <166445701+jtigue-bdai@users.noreply.github.com>
jtigue-bdai
commented
Oct 15, 2024
source/extensions/omni.isaac.lab/test/utils/test_configclass.py
Outdated
Show resolved
Hide resolved
Mayankm96
changed the title
Mayankm96
changed the title
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
changed the title
to_dict operation to handle a list of configclasses
|
Thanks for the fix! Do we need to do something for dict to class operation too? Or that works as expected? |
|
Ah that is a good question. I will have to look at that. |
3 tasks
|
@jtigue-bdai @Mayankm96 yes this works correctly and is tested here: |
Dhoeller19
approved these changes
Oct 24, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…ses (isaac-sim#1227) # Description This PR add in the ability to properly convert configclass to dict if a configclass instance contains a list of configclasses. Fixes isaac-sim#1219 ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add in the ability to properly convert configclass to dict if a configclass instance contains a list of configclasses.
Fixes #1219
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there