-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a render config to the simulation and tiledCamera limitations to the docs #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_context.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_context.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_cfg.py
Outdated
Show resolved
Hide resolved
Signed-off-by: David Hoeller <dhoeller@nvidia.com>
Dhoeller19
approved these changes
Oct 23, 2024
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
… the docs (isaac-sim#1246) # Description This change adds a render config to the simulation context and highlights current limitations and workarounds for issues with the TiledCamera class. ## Type of change - This change requires a documentation update ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds a render config to the simulation context and highlights current limitations and workarounds for issues with the TiledCamera class.
Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there