Expands observation term scaling to support list of floats #1269
+44
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal-roth
requested review from
jsmith-bdai,
Dhoeller19,
Mayankm96 and
kellyguo11
as code owners
Dhoeller19
reviewed
Oct 19, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/observation_manager.py
Outdated
Show resolved
Hide resolved
Mayankm96
reviewed
Oct 22, 2024
source/extensions/omni.isaac.lab/omni/isaac/lab/managers/manager_term_cfg.py
Outdated
Show resolved
Hide resolved
Mayankm96
requested changes
Oct 22, 2024
Co-authored-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com> Co-authored-by: David Hoeller <dhoeller@nvidia.com> Signed-off-by: Pascal Roth <57946385+pascal-roth@users.noreply.github.com>
|
@Mayankm96 test are added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support to define tuple of floats to scale observation terms by expanding the
ObservationManagerCfg.scaleattribute.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there