Adds sanity check for the term type inside the command manager #1315
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
command-z-z
requested review from
jsmith-bdai,
Dhoeller19,
Mayankm96 and
kellyguo11
as code owners
The iteration over group_cfg.__dict__.items() was replaced with group_cfg_items to ensure the correct items are iterated over. This fixes potential issues with non-observation settings being processed incorrectly.
Mayankm96
approved these changes
Oct 31, 2024
Mayankm96
changed the title
Mayankm96
reviewed
Nov 1, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Mayankm96
reviewed
Nov 1, 2024
Mayankm96
reviewed
Nov 1, 2024
Signed-off-by: Mayank Mittal <12863862+Mayankm96@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this change is to enhance the robustness of the code by adding a sanity check to ensure that the command term is of a valid type before it is processed (Just like ActionTerm). This validation step is crucial for preventing unexpected errors and maintaining system stability, especially when dealing with dynamically configured command terms that may vary based on external inputs or configurations. By validating the type of the command term, we can provide early feedback to developers and users, helping to catch misconfigurations or type mismatches during the initial stages. This change aims to improve the overall reliability and maintainability of the codebase.
It also fixes iteration over group_cfg_items inside the observation manager.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there