Adds figures for manager-based and direct RL environments #1337
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
….jpg Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
OOmotuyi
requested review from
jsmith-bdai,
Dhoeller19,
kellyguo11 and
Mayankm96
as code owners
kellyguo11
approved these changes
Oct 30, 2024
kellyguo11
changed the title
This was referenced Oct 30, 2024
Mayankm96
added a commit
that referenced
this pull request
Nov 4, 2024
# Description This MR fixes the regression in #1337. The images were located in the wrong directory. Please be careful. P.S.: The images are very low in resolution, and they don't support the dark theme. It would be great to include this as part of this MR to avoid this issue. ## Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Mayankm96
added a commit
that referenced
this pull request
Nov 4, 2024
This MR fixes the regression in #1337. The images were located in the wrong directory. Please be careful. P.S.: The images are very low in resolution, and they don't support the dark theme. It would be great to include this as part of this MR to avoid this issue. - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
…#1337) # Description Adding reference flow diagram for manager-based and direct RL task workflows <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change - Documentation Change ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [ ] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Signed-off-by: OOmotuyi <159472067+OOmotuyi@users.noreply.github.com>
iamdrfly
pushed a commit
to iamdrfly/IsaacLab
that referenced
this pull request
Nov 21, 2024
This MR fixes the regression in isaac-sim#1337. The images were located in the wrong directory. Please be careful. P.S.: The images are very low in resolution, and they don't support the dark theme. It would be great to include this as part of this MR to avoid this issue. - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [x] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding reference flow diagram for manager-based and direct RL task workflows
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there