-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaces TensorDict with native dictionary #1348
Conversation
Before a more detailed review, I was wondering what is the reason why we should prefer normal dicts instead of Tensordict (thought we would rather use more and not less tensordicts in the code)? |
|
Okay makes sense to me, it was anyway basically the only place where we use them. @Mayankm96 if I remember correctly then you were in favor of using them, so tagging you here for viz |
Hey just a couple of comments based on the above discussion (not hoping that this PR will be reverted but I thought some of these comments were worth addressing)
TensorDict does support tuples (it supports basically any python object) although most APIs won't work (like
On that I cannot disagree, it's definitely written for pytorch! hmmm ok?! I'd just say that nested keys isn't really the main feature of the lib (and |
# Description Remove TensorDict usage from Isaac Lab ## Type of change - Breaking change... for those ones using TensorDict specific API such as `camera.data.output.to_dict()` or `camera.data.output.sorted_keys` ## Screenshots Before ![Screenshot from 2024-10-30 12-45-06](https://github.com/user-attachments/assets/2dc0e827-3e12-4ae9-849e-e9f75c718157) After ![Screenshot from 2024-10-30 16-04-35](https://github.com/user-attachments/assets/715b6cb0-9f87-4938-8dbd-5c56203cb90e) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> --------- Co-authored-by: Kelly Guo <kellyguo123@hotmail.com>
Description
Remove TensorDict usage from Isaac Lab
Type of change
camera.data.output.to_dict()
orcamera.data.output.sorted_keys
Screenshots
Before
After
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there